Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git.ignoreLegacyWarning written to workspace settings instead of user settings #33440

Closed
mjbvz opened this issue Aug 29, 2017 · 3 comments
Closed

git.ignoreLegacyWarning written to workspace settings instead of user settings #33440

mjbvz opened this issue Aug 29, 2017 · 3 comments
Assignees
@sandy081
Labels
api bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues verified Verification succeeded
Milestone
August 2017

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Aug 29, 2017

Testing #33278

Steps to Reproduce:
On a machine with an old version of git:

  1. Open a code-workspace
  2. Observe git 2.0 upgrade warning
  3. Click Dont show again

Expected
"git.ignoreLegacyWarning": true is written to user settings

Actual
"git.ignoreLegacyWarning": true is written to the workspace settings:

{
	"folders": [
		{
			"path": "folder2"
		}
	],
	"settings": {
		"git.ignoreLegacyWarning": true
	}
}
@joaomoreno joaomoreno added this to the August 2017 milestone Aug 30, 2017
@joaomoreno
Copy link
Member

Good catch.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Aug 30, 2017
@joaomoreno joaomoreno assigned sandy081 and unassigned joaomoreno Aug 30, 2017
@joaomoreno
Copy link
Member

@sandy081 I seem to be doing the right thing here:

https://github.com/Microsoft/vscode/blob/master/extensions/git/src/main.ts#L94

sandy081 added a commit that referenced this issue Aug 30, 2017
@sandy081
Tests for #33440
12f4688
@sandy081
Copy link
Member

Good catch.

Yeah its a bug from side. Classic bug: Having a check on an Enum starting with 0.

@sandy081 sandy081 added api config VS Code configuration, set up issues and removed git GIT issues labels Aug 30, 2017
@sandy081 sandy081 mentioned this issue Aug 30, 2017
Closed
@chrmarti chrmarti mentioned this issue Aug 30, 2017
Closed
@mjbvz mjbvz added the verified Verification succeeded label Aug 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
api bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@joaomoreno @sandy081 @mjbvz