Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Go to File..." shows files in search.exclude #33444

Closed
michaeljonathanblack opened this issue Aug 29, 2017 · 1 comment
Closed

"Go to File..." shows files in search.exclude #33444

michaeljonathanblack opened this issue Aug 29, 2017 · 1 comment
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
August 2017

Comments

@michaeljonathanblack
Copy link

"Go to File..." is essentially a search operation and should be be managed by search.exclude, or optionally an additional config, e.g. goto.exclude. Typical use-case is having Explorer reflect true contents of project (e.g. not hiding generated files), while other operations are for navigating files one will edit.

  • VSCode Version: @latest
  • OS Version: OS X

Steps to Reproduce:

  1. Include node_modules in search.exclude, but not in files.exclude in settings
  2. cmd + p
  3. See excluded files appearing in results
@vscodebot vscodebot bot added the search Search widget and operation issues label Aug 29, 2017
@roblourens
Copy link
Member

It is supposed to respect search.exclude but there seems to be a problem with having **/node_modules": false in files.exclude...

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Aug 29, 2017
@roblourens roblourens added this to the August 2017 milestone Aug 29, 2017
@mjbvz mjbvz added the verified Verification succeeded label Aug 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@roblourens @michaeljonathanblack @mjbvz