Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag/Drop of folder named "tmp" does nothing #33466

Closed
chrisdias opened this issue Aug 29, 2017 · 4 comments
Closed

Drag/Drop of folder named "tmp" does nothing #33466

chrisdias opened this issue Aug 29, 2017 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2017

Comments

@chrisdias
Copy link
Member

Testing #33275

image

I have a folder called tmp and all it has in it is a json file:

image

When I drag/drop it to the explorer, nothing happens:

tmpfolderdnd
@chrisdias chrisdias added this to the August 2017 milestone Aug 29, 2017
@chrisdias chrisdias changed the title Drag/Drop of tmp folder does nothing Drag/Drop of tmp folder does nothing Aug 29, 2017
@chrisdias
Copy link
Member Author

D/D of a folder without any content "fails" as well, but the tmp folder i have on disk has one file.

If i d/d the tmp folder to the editor space (NOT the Explorer), I get a prompt to save an existing workspace (I say No) and then the editor is restarted with tmp folder opened.

@chrisdias
Copy link
Member Author

One more update... I can do File | Add Folder to Workspace and include the tmp folder or any empty folder.

@ghiscoding
Copy link

@chrisdias I saw in the insiders 1.16 doc that the drag and drop now only works when dragging in the editor area (not the solution explorer like you are trying). See the docs here for open a folder via drag and drop

@chrisdias
Copy link
Member Author

@ghiscoding I can drag folders into the Explorer to add to the existing workspace. What I can't do is drag this particular folder or empty folders. Other folders can be dragged into the Explorer just fine.

@bpasero ?

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 30, 2017
@bpasero bpasero changed the title Drag/Drop of tmp folder does nothing Drag/Drop of folder named "tmp" does nothing Aug 30, 2017
@bpasero bpasero removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 30, 2017
@bpasero bpasero closed this as completed Aug 30, 2017
bpasero added a commit that referenced this issue Aug 30, 2017
@bpasero
Drag/Drop of folder named "tmp" does nothing (fixes #33466)
d718d20
@mjbvz mjbvz added the verified Verification succeeded label Aug 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
4 participants
@ghiscoding @bpasero @chrisdias @mjbvz