Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--add of multiple folders should add to existing instance, not open new instance #33469

Closed
chrisdias opened this issue Aug 29, 2017 · 3 comments
Closed

--add of multiple folders should add to existing instance, not open new instance #33469

chrisdias opened this issue Aug 29, 2017 · 3 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone
August 2017

Comments

@chrisdias
Copy link
Member

testing #33275

image

Consider the following three command lines:

a) code-insiders -a <folder> will add the folder to an existing instance
b) code-insiders -a <folder1> <folder2> will open a new instance of code with the two folders
c) code-insiders <folder1> <folder2> will open a new instance of code with the two folders

The behaviors for b and c are the same. My expectation is that b would add to an instance while c would open a new instance. Since they currently behave the same, I suggesting making b add to an instance.
@chrisdias chrisdias added this to the August 2017 milestone Aug 29, 2017
@bpasero
Copy link
Member

bpasero commented Aug 30, 2017

Great catch 👍

@bpasero bpasero closed this as completed Aug 30, 2017
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-multiroot Multi-root (multiple folders) issues workbench labels Aug 30, 2017
bpasero added a commit that referenced this issue Aug 30, 2017
@bpasero
--add of multiple folders should add to existing instance, not open n…
ca1f12c 
…ew instance (fixes #33469)
@isidorn isidorn added the verified Verification succeeded label Sep 1, 2017
@isidorn
Copy link
Contributor

isidorn commented Sep 1, 2017

Works fine if I have a workspace with single root open, however does not work if I have a MR workspace with folders A and B and I try to add C and D. The command simply gets ignored

@isidorn isidorn reopened this Sep 1, 2017
@isidorn isidorn added verification-found Issue verification failed and removed verified Verification succeeded labels Sep 1, 2017
@isidorn
Copy link
Contributor

isidorn commented Sep 1, 2017

My unsaved workspace was somehow in a bad state. Once closing vscode and reopining I can no longer repro -> closing

@isidorn isidorn closed this as completed Sep 1, 2017
@isidorn isidorn added verified Verification succeeded and removed verification-found Issue verification failed labels Sep 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@bpasero @chrisdias @isidorn