Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakpoint messages no longer shown when hovering the breakpoint indicator #33480

Closed
roblourens opened this issue Aug 30, 2017 · 3 comments
Closed

Breakpoint messages no longer shown when hovering the breakpoint indicator #33480

roblourens opened this issue Aug 30, 2017 · 3 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
August 2017

Comments

@roblourens
Copy link
Member

  • Debug a node app or extension with node2, but mess up the sourcemaps or something so the breakpoints are gray
  • You should see a message when you hover the cursor over the breakpoint decoration, but you don't. I do see it when I hover over the breakpoint entry in the sidebar, but not the editor margin decoration.
@roblourens roblourens added the debug Debug viewlet, configurations, breakpoints, adapter issues label Aug 30, 2017
@isidorn isidorn added this to the August 2017 milestone Aug 30, 2017
@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2017

Via bisect I have found that commit 0614806 has broken this
Forwarding to @jrieken to investigate further since those util methods might break other stuff as well

Easier repro steps: add a conditional breakpoint, hover over it -> it should show the condition, it does not

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Aug 30, 2017
@isidorn isidorn assigned jrieken and unassigned isidorn Aug 30, 2017
@jrieken
Copy link
Member

jrieken commented Aug 30, 2017

Most likely a dupe of #33486

@isidorn How do you create your hover messages? Do you use a stringor something like {language: foo, value: fool_and_code}?

@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2017

In one of the two ways, both do not seem to work
const glyphMarginHoverMessage = new MarkdownString().appendCodeblock(modeId, condition);
new MarkdownString().appendText(breakpoint.message);

More details https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/browser/debugEditorModelManager.ts#L309

@isidorn isidorn added the verified Verification succeeded label Aug 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@roblourens @jrieken @isidorn