Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debounce on file read #33529

Closed
isidorn opened this issue Aug 30, 2017 · 1 comment
Closed

Debounce on file read #33529

isidorn opened this issue Aug 30, 2017 · 1 comment
Assignees
@bpasero
Labels
debt Code quality issues
Milestone
September 2017

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2017

If a file is getting updated every 500ms and we need 1000ms to read that file we end up in a spot where we have too many file reads since they do not get canceled.
Optimally we would cancel an outdated file read if we need to read that file again.

Example program / large file can be found here #33378

fyi @alexandrudima
@isidorn isidorn added the debt Code quality issues label Aug 30, 2017
@bpasero bpasero added this to the September 2017 milestone Aug 30, 2017
@alexdima
Copy link
Member

alexdima commented Aug 30, 2017 •
edited

I've just checked the window also freezes on stable, so it is not a regression caused by preserving the undo stack in this case.

I think this also causes some jumping around to happen. If I follow Isidor's steps the view/cursor jumps around all the time. I think there are some code paths that restore the view state or something.

@alexdima alexdima mentioned this issue Aug 30, 2017
Closed
@bpasero bpasero closed this as completed in 193b1cb Sep 4, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@bpasero @isidorn @alexdima