Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-account extension is missing licenses #33587

Closed
weinand opened this issue Aug 31, 2017 · 1 comment
Closed

azure-account extension is missing licenses #33587

weinand opened this issue Aug 31, 2017 · 1 comment
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority

Comments

@weinand
Copy link
Contributor

weinand commented Aug 31, 2017 •
edited

I was running the OSS tool today and it found several issues:

  • do not add devDependencies to the npm-shrinkwrap.json. I've already removed them.

  • the OSS tool reported these errors:
    ERROR: aws-sign2@0.6.0: Missing Copyright statement in license text!
    ERROR: azure-arm-resource@2.0.0-preview: Missing Copyright statement in license text!
    ERROR: bcrypt-pbkdf@1.0.1: No license detail found at repositoryURL: null
    ERROR: caseless@0.12.0: Missing Copyright statement in license text!
    ERROR: copy-paste@1.3.0: Missing Copyright statement in license text!
    ERROR: forever-agent@0.6.1: Missing Copyright statement in license text!
    ERROR: json-schema@0.2.3: No license detail found at repositoryURL: https://github.com/kriszyp/json-schema
    ERROR: jsonify@0.0.0: No license detail found at repositoryURL: https://github.com/substack/jsonify
    ERROR: ms-rest-azure@2.2.3: Missing Copyright statement in license text!
    ERROR: ms-rest@2.2.1: Missing Copyright statement in license text!
    ERROR: oauth-sign@0.8.2: Missing Copyright statement in license text!
    ERROR: tunnel-agent@0.6.0: Missing Copyright statement in license text!
    ERROR: tweetnacl@0.14.5: Missing Copyright statement in license text!
    ERROR: windows-process-tree@0.1.3: No license detail found at repositoryURL: null
    ERROR: xmldom@0.1.27: Missing Copyright statement in license text!
    ERROR: xpath.js@1.0.7: Missing Copyright statement in license text!

As an example we've already added an Apache license for the "request" npm module.
@weinand weinand added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Aug 31, 2017
weinand added a commit that referenced this issue Aug 31, 2017
@weinand
add a license override for "request" npm module; see #33587
04d0ad2
weinand added a commit that referenced this issue Aug 31, 2017
@weinand
remove devDependencies from shrinkwrap: see #33587
70d47c3
@weinand weinand added this to the August 2017 milestone Aug 31, 2017
@weinand weinand changed the title azure-account is missing licenses azure-account extension is missing licenses Aug 31, 2017
jrieken pushed a commit that referenced this issue Sep 1, 2017
@weinand @jrieken
add a license override for "request" npm module; see #33587
1df05b7
jrieken pushed a commit that referenced this issue Sep 1, 2017
@weinand @jrieken
remove devDependencies from shrinkwrap: see #33587
aa992df
@chrmarti chrmarti removed this from the August 2017 milestone Sep 1, 2017
@chrmarti
Copy link
Contributor

chrmarti commented Sep 1, 2017

We have removed the extension.

@chrmarti chrmarti closed this as completed Sep 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weinand @chrmarti