Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using smooth scrolling, the diff editor does not jump to the first change #33659

Closed
alexdima opened this issue Sep 1, 2017 · 4 comments
Closed

When using smooth scrolling, the diff editor does not jump to the first change #33659

alexdima opened this issue Sep 1, 2017 · 4 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
May 2018

Comments

@alexdima
Copy link
Member

alexdima commented Sep 1, 2017

  • have "editor.smoothScrolling": true
  • close all editors
  • click on a change
  • the scroll is somewhere between the top of the file and the first change

kapture 2017-09-01 at 11 31 09
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Sep 1, 2017
@alexdima alexdima added this to the August 2017 milestone Sep 1, 2017
@alexdima alexdima self-assigned this Sep 1, 2017
@alexdima
Copy link
Member Author

alexdima commented Sep 1, 2017

I cannot reproduce on master after pulling, so I think some other (perhaps git related) fixes also fixed this case.

@alexdima alexdima closed this as completed Sep 1, 2017
@roblourens
Copy link
Member

I can still repro this in the latest Insiders

@roblourens roblourens reopened this Sep 1, 2017
@roblourens roblourens added the verification-found Issue verification failed label Sep 1, 2017
@alexdima
Copy link
Member Author

alexdima commented Sep 4, 2017

Let's investigate in September. It only happens when editor.smoothScrolling is on (it is off by default).

@alexdima alexdima modified the milestones: September 2017, August 2017 Sep 4, 2017
@alexdima alexdima modified the milestones: September 2017, On Deck Sep 28, 2017
@eamodio
Copy link
Contributor

eamodio commented Nov 8, 2017

I can still reproduce this - although it isn't 100% reproducible

@alexdima alexdima removed the verification-found Issue verification failed label Nov 13, 2017
@alexdima alexdima modified the milestones: On Deck, May 2018 Apr 30, 2018
@chrmarti chrmarti added the verified Verification succeeded label May 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
4 participants
@roblourens @eamodio @alexdima @chrmarti