Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Markdown references links #33714

Closed
mjbvz opened this issue Sep 1, 2017 · 4 comments
Closed

Detect Markdown references links #33714

mjbvz opened this issue Sep 1, 2017 · 4 comments
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality markdown Markdown support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2017

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Sep 1, 2017 •
edited

Feature Request
For the markdown:

text [more info][autosave] text

[autosave]: /docs/editor/codebasics.md#saveauto-save

Detect autosave in [autosave] as a link to /docs/editor/codebasics.md#saveauto-save

Related to #25861
@mjbvz mjbvz added feature-request Request for new features or functionality markdown Markdown support issues labels Sep 1, 2017
@mjbvz mjbvz added this to the September 2017 milestone Sep 1, 2017
@mjbvz mjbvz self-assigned this Sep 1, 2017
@mjbvz mjbvz closed this as completed in 465c3ed Sep 1, 2017
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Sep 1, 2017
@jrieken jrieken reopened this Sep 26, 2017
@jrieken
Copy link
Member

jrieken commented Sep 26, 2017

doesn't work for non-ascii strings, like

text [more info][autösave] text

[autösave]: /docs/editor/codebasics.md#saveauto-save

@jrieken jrieken added the verification-found Issue verification failed label Sep 26, 2017
@mjbvz mjbvz closed this as completed in 4dd1244 Sep 26, 2017
@jrieken jrieken removed the verification-found Issue verification failed label Sep 27, 2017
@jrieken
Copy link
Member

jrieken commented Sep 27, 2017

doesn't work for escaped closed square brackts

text [more info][aut\]ösave] text

[aut\]ösave]: /docs/editor/codebasics.md#saveauto-save

@jrieken jrieken reopened this Sep 27, 2017
@jrieken jrieken added the verification-found Issue verification failed label Sep 27, 2017
@mjbvz mjbvz mentioned this issue Sep 27, 2017
Closed
@mjbvz
Copy link
Contributor Author

mjbvz commented Sep 27, 2017

@jrieken Opened #35245 to track this. Please open new bugs if you discover any other edge cases

@mjbvz mjbvz closed this as completed Sep 27, 2017
@octref octref removed the verification-found Issue verification failed label Sep 27, 2017
@jrieken
Copy link
Member

jrieken commented Sep 28, 2017

Yeah, just stop using regular expressions for parsing

@jrieken jrieken added the verified Verification succeeded label Sep 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality markdown Markdown support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@jrieken @octref @mjbvz