Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor history lost when closing inactive group #33997

Closed
bpasero opened this issue Sep 8, 2017 · 3 comments
Closed

Editor history lost when closing inactive group #33997

bpasero opened this issue Sep 8, 2017 · 3 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2017

Comments

@bpasero
Copy link
Member

bpasero commented Sep 8, 2017

Steps to Reproduce:

  1. have 2 files open side by side
  2. be in the first file to the left and navigate around (at least 10 lines apart) to produce some editor history
  3. navigate back
  4. close inactive editor on the right hand side
  5. try to navigate forward

=> history is lost after the point where the inactive editor is closed because we wrongly treat that as a editor navigation event
@bpasero bpasero self-assigned this Sep 8, 2017
@vscodebot vscodebot bot added the workbench label Sep 8, 2017
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 8, 2017
@bpasero bpasero added this to the September 2017 milestone Sep 8, 2017
@bpasero bpasero closed this as completed in 30b8bbb Sep 8, 2017
@roblourens
Copy link
Member

How do you close the inactive editor? I can't repro this in 1.16.

@bpasero
Copy link
Member Author

bpasero commented Sep 28, 2017

@roblourens you can close it by just clicking the close button of the tab without making the editor active!

@roblourens
Copy link
Member

roblourens commented Sep 28, 2017 •
edited

That's what I'm doing. But I also can't repro it in 1.17...

@roblourens roblourens added the verified Verification succeeded label Sep 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
2 participants
@roblourens @bpasero