Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorkspaceStats performance considerations #34033

Closed
jrieken opened this issue Sep 8, 2017 · 5 comments
Closed

WorkspaceStats performance considerations #34033

jrieken opened this issue Sep 8, 2017 · 5 comments
Assignees
@chrmarti
Labels
perf perf-startup
Milestone
November 2017

Comments

@jrieken
Copy link
Member

jrieken commented Sep 8, 2017 •
edited

Stumbled over this, a couple of ideas/questions..

  • run with a delay on not immediately on startup, today this seems to be on the critical path
  • we read N workspace folders, with each M files, and check K patterns against that...
  • can this be an extension?
@jrieken jrieken added the perf label Sep 8, 2017
@jrieken
Copy link
Member Author

jrieken commented Nov 13, 2017

related to #38080

@bpasero
Copy link
Member

bpasero commented Nov 13, 2017 •
edited

@chrmarti fyi I converted workspace stats to be a workbench contribution with the new support of instantiating these contributions in a certain lifecycle phase (via 6b30ade and fa592ef). With my change, the stats are only computed and recorded after 3s.

@chrmarti
Copy link
Contributor

Great, thanks @bpasero! Is there anything left to do here?

@bpasero
Copy link
Member

bpasero commented Nov 14, 2017

@chrmarti I would say, up to @jrieken as author to decide.

@jrieken
Copy link
Member Author

jrieken commented Nov 14, 2017

we read N workspace folders, with each M files, and check K patterns against that...

I think we still loop a lot

@chrmarti chrmarti added this to the November 2017 milestone Nov 15, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
perf perf-startup
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
3 participants
@bpasero @jrieken @chrmarti