Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal: lost sub-pixel anti aliasing #34119

Closed
bpasero opened this issue Sep 11, 2017 · 4 comments
Closed

Terminal: lost sub-pixel anti aliasing #34119

bpasero opened this issue Sep 11, 2017 · 4 comments
Assignees
Labels
terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@bpasero
Copy link
Member

bpasero commented Sep 11, 2017

Looks like the new canvas solution means we no longer get sub-pixel anti aliasing:

image

@bpasero bpasero added the terminal Integrated terminal issues label Sep 11, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2017

It is possible to do with canvas but it requires that the background of the text not be transparent. Will need some rework.

Without:

image

WIth:

image

@Tyriar Tyriar added this to the October 2017 milestone Sep 11, 2017
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 11, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2017

I'm not sure why but this has never worked for me in the old model on Linux or macOS (just tested on stable). Perhaps this means we can consistently get the text rendering properly on all platforms as I can git it rendering with AA quite easily in a proof of concept.

@bpasero
Copy link
Member Author

bpasero commented Sep 11, 2017

@Tyriar there are some conditions under which sub-pixel AA stops working, I suggest you check https://www.html5rocks.com/en/tutorials/internals/antialiasing-101/

@Tyriar
Copy link
Member

Tyriar commented Sep 13, 2017

@bpasero yeah I remember looking into that when I was trying to get it working but couldn't figure it out. Regardless, I got it working very easily on canvas when trying, so when it's done in xtermjs/xterm.js#973 it should work consistently for everyone 😃

@Tyriar Tyriar modified the milestones: October 2017, September 2017 Sep 14, 2017
@Tyriar Tyriar closed this as completed in aea2c05 Sep 14, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants