Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript snippets don't work in JavaScript React #3415

Closed
janmarek opened this issue Feb 24, 2016 · 3 comments
Closed

JavaScript snippets don't work in JavaScript React #3415

janmarek opened this issue Feb 24, 2016 · 3 comments
Assignees
Labels
polish Cleanup and polish issue
Milestone

Comments

@janmarek
Copy link

When I type for example "fun" and press tab I expect to see

function name(params) {

}

but I see

<fun></fun>

instead.

@egamma egamma added the polish Cleanup and polish issue label Feb 24, 2016
@egamma egamma added this to the Feb 2016 milestone Feb 24, 2016
@egamma
Copy link
Member

egamma commented Feb 24, 2016

This comes from emmet which we enabled for React.

<fun></fun>

@aeschli Suggest to also register the javascript.json snippets for javascriptreact.

Suggest to get this in for Feb since we will say that we improve the .jsx support.

@joaomoreno joaomoreno assigned joaomoreno and unassigned aeschli Feb 26, 2016
@joaomoreno joaomoreno assigned aeschli and unassigned joaomoreno Feb 26, 2016
@janmarek
Copy link
Author

Would it be possible for javascriptreact to inherit (user defined) javascript snippets?

@deathmood
Copy link

just downloaded 0.10.10-insiders --- and it expands to function definition. But there is another problem --- *.js files with jsx inside are opened as JavaScript and emmet does not work. But if I switch language to JavaScript React emmet works.

Is there any possibility to enable emmet in files with *.js extension?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

5 participants