Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated terminal prompt cut of on first boot. #34243

Closed
MEXdave1997 opened this issue Sep 12, 2017 · 4 comments
Closed

Integrated terminal prompt cut of on first boot. #34243

MEXdave1997 opened this issue Sep 12, 2017 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
September 2017

Comments

@MEXdave1997
Copy link

MEXdave1997 commented Sep 12, 2017 •
edited

  • VSCode Version: 1.17.0-insider
  • OS Version: Windows 10 Build 15063.540

Steps to Reproduce:

  1. Launch VSCode Insider
  2. Open Integrated Terminal in the prefered way.

Reproduces without extensions: Yes/No

Comment:
This isn't really a major issue, but it is kind of annyoing that the integrated terminal gets thrown off its positioning on first boot. Below is an image of the integrated terminal opened on first boot:
screenshot 56

EDIT: This is also on VSCode Stable Version 1.16
@vscodebot vscodebot bot added insiders terminal Integrated terminal issues labels Sep 12, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 12, 2017

@MEXdave1997 thanks for the report, I have some follow ups:

  • Can you share your settings.json file?
  • Does this happen whenever you create a terminal or just for the first one?
  • Does the issue go away completely after resizing the panel?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Sep 12, 2017
@Tyriar Tyriar added this to the September 2017 milestone Sep 12, 2017
@MEXdave1997
Copy link
Author

Ill answer some of these questions here:

  • The settings.json files for both versions can be found in this gist.
  • Yes, this happens pretty much every time I open the integrated terminal panel.
  • No, in fact, the issue gets worse if I make the panel larger, and changes very minimally as I make the panel smaller.

@Tyriar Tyriar closed this as completed in d5865f0 Sep 13, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 13, 2017

I pushed a fix for this.

@roblourens a quick verification on your mac would be appreciated as I wasn't seeing it quite as bad as you were.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Sep 13, 2017
@MEXdave1997
Copy link
Author

I will try the fix now, and will update if anything comes up. Thank you for this! 😄

@Tyriar Tyriar mentioned this issue Sep 13, 2017
Closed
@roblourens roblourens added the verified Verification succeeded label Sep 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@roblourens @Tyriar @MEXdave1997