Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal parsing on Windows is significantly slower due to resetting timers #34328

Closed
Tyriar opened this issue Sep 13, 2017 · 2 comments
Closed

Terminal parsing on Windows is significantly slower due to resetting timers #34328

Tyriar opened this issue Sep 13, 2017 · 2 comments
Assignees
@Tyriar
Labels
perf terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 13, 2017 •
edited

The timer is reset on a lineFeed event which happens many times during a parsing round. It looks like parsing is around 3-5 times slower than Linux/macOS because of this, dropping the framerate quite a bit.

image
@Tyriar Tyriar added terminal Integrated terminal issues perf labels Sep 13, 2017
@Tyriar Tyriar added this to the September 2017 milestone Sep 13, 2017
@Tyriar Tyriar self-assigned this Sep 13, 2017
@Tyriar Tyriar closed this as completed in 2a4cf4f Sep 13, 2017
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Sep 13, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Sep 13, 2017

To verifier: please check that the shell name feature still works on Windows. When you run cmd inside powershell, the terminal title should change to cmd.

@Tyriar Tyriar changed the title Terminal parsing on Windows is significantly slower due to resetting times Terminal parsing on Windows is significantly slower due to resetting timers Sep 13, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Sep 13, 2017

After the fix (both running tree:

image

@roblourens roblourens added the verified Verification succeeded label Sep 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
perf terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
2 participants
@roblourens @Tyriar