Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[html] support script type=module #34488

Closed
ValentineStone opened this issue Sep 15, 2017 · 4 comments
Closed

[html] support script type=module #34488

ValentineStone opened this issue Sep 15, 2017 · 4 comments
Assignees
@aeschli
Labels
feature-request Request for new features or functionality html HTML support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2017

Comments

@ValentineStone
Copy link

  • VSCode Version: 1.16.1
  • OS Version: Windows 10 ( Creators Update )

Steps to Reproduce:

  1. Create new file & save it as .html
  2. Open file in VSCode and add some content like so:
<script type="module">
'line1';
'line2';
"any multiline content: functions 'n stuff...";
</script>
  1. Right click on the editor and select Format Document from the context menu
  2. You should get some like this:
<script type="module">
  'line1'; 'line2'; "any multiline content: functions 'n stuff...";
</script>
  1. As you can see, auto-formatter puts everything on one line :/

Reproduces without extensions: Yes
@aeschli aeschli added the html HTML support issues label Sep 18, 2017
@aeschli aeschli changed the title <script type="module"> auto-formatted into single line [html] script type=module not supported Sep 18, 2017
@aeschli aeschli changed the title [html] script type=module not supported [html] support script type=module Sep 18, 2017
@aeschli aeschli added this to the September 2017 milestone Sep 20, 2017
@aeschli aeschli added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Sep 25, 2017
@roblourens
Copy link
Member

I see the same behavior...

@roblourens roblourens reopened this Sep 27, 2017
@roblourens roblourens added the verification-found Issue verification failed label Sep 27, 2017
@aeschli
Copy link
Contributor

aeschli commented Sep 27, 2017 •
edited

@roblourens Strange. When I format

<script type="module">
'line1';
'line2';
"any multiline content: functions 'n stuff...";
</script>

all stays on separate line (plus indent) which is what is expected:

 <script type="module">
  'line1';
  'line2';
  "any multiline content: functions 'n stuff...";
</script>

Do you have more details?

@aeschli aeschli removed the verification-found Issue verification failed label Sep 27, 2017
@aeschli
Copy link
Contributor

aeschli commented Sep 27, 2017

Maybe someone else can verify as well...

@aeschli aeschli closed this as completed Sep 27, 2017
@roblourens
Copy link
Member

Some extension. But I can't figure out which one...

@roblourens roblourens added the verified Verification succeeded label Sep 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality html HTML support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@roblourens @aeschli @ValentineStone