Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot read property 'resourceJSON' of null #34490

Closed
chrisdias opened this issue Sep 15, 2017 · 11 comments
Closed

cannot read property 'resourceJSON' of null #34490

chrisdias opened this issue Sep 15, 2017 · 11 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2017

Comments

@chrisdias
Copy link
Member

MacOS
Version 1.17.0-insider (1.17.0-insider)
b0c0634

scaffold a new extension
run the extension
in the [Extension Development Host] press Cmd+P to bring up the command palette

Result: error: cannot read property 'resourceJSON' of null

Console from Extension Development Host:

/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:29 Cannot read property 'resourceJSON' of null: TypeError: Cannot read property 'resourceJSON' of null
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:29:191627
    at t.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:28:1087764)
    at e.deserialize (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:29:191577)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:28:2490886
    at Array.map (native)
    at t.loadHistory (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:28:2490702)
    at t.ensureHistoryLoaded (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:28:2490029)
    at t.handleEditorEventInHistory (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:28:2485825)
    at t.handleActiveEditorChange (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:28:2485639)
    at t.e.onEditorsChanged (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:28:2481621)

F1 works fine, I can bring up the command palette.
@alexdima
Copy link
Member

I could find references of resourceJSON in some serialized file inputs interfaces...

@bpasero
Copy link
Member

bpasero commented Sep 18, 2017

Not possible from the source code, but I added paranoia code even though I cannot explain this.

@bpasero bpasero added this to the September 2017 milestone Sep 18, 2017
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 18, 2017
@kumarharsh
Copy link
Contributor

+1 happening to me too. I was working on my extension (say, C:\Extension), and to test it out, I opened my usual work directory (D:\Work) in the EDH. I later closed the EDH, and in the main vscode-insider window, I switched to the same work directory (D:\Work), and I kept getting this error. And now, even after restarting vscode and even updating it to a new version, I just keep getting this error, in effect, I can't use vscode-insider now :/

The error:
image

The "Ctrl+P" palette is empty:
image

@bpasero
Copy link
Member

bpasero commented Sep 20, 2017

@kumarharsh you are still seeing this in todays insider build?

@kumarharsh
Copy link
Contributor

Yes. I posted my reply only after verifying that it didn't work after updating. Never saw this bug coming, and thought it'd be trivial to fix by just reloading window. Boy, was I wrong 😢 !

Using the stable channel for now.

@bpasero
Copy link
Member

bpasero commented Sep 20, 2017

@kumarharsh can you show me a screenshot of your about dialog? also, can you send me the crash from the developer console (Help > Developer Console)

@kumarharsh
Copy link
Contributor

kumarharsh commented Sep 20, 2017 •
edited

image

This is the error stack:
image

bpasero added a commit that referenced this issue Sep 20, 2017
@bpasero
more fixes for #34490
10eb2b7
@bpasero
Copy link
Member

bpasero commented Sep 20, 2017

@kumarharsh thanks, I am working on a fix and will ping you to give it a try.

@deysaikat95 deysaikat95 mentioned this issue Sep 25, 2017
Closed
@kumarharsh
Copy link
Contributor

@bpasero did your changes get rolled up into a release? My editor always says "No updates available" when I check for updates. The version is the same as in the screenshot above.

@bpasero
Copy link
Member

bpasero commented Sep 27, 2017

@kumarharsh we are currently not able to provide updates because our signing service does not run, please be patient for our next stable release.

@kumarharsh
Copy link
Contributor

kumarharsh commented Sep 27, 2017 •
edited

I'm patient :-) I asked because I was concerned whether the update service was also not broken.

next stable release.

So, the insider builds are stopped until october?

@roblourens roblourens added the verified Verification succeeded label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
5 participants
@roblourens @kumarharsh @bpasero @chrisdias @alexdima