Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use embeddedLanguages to mark markdown fenced code block content types #34598

Closed
mjbvz opened this issue Sep 18, 2017 · 1 comment
Closed

Use embeddedLanguages to mark markdown fenced code block content types #34598

mjbvz opened this issue Sep 18, 2017 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues verified Verification succeeded
Milestone
September 2017

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Sep 18, 2017

Bug
Inside markdown fenced code blocks, the language mode is always markdown. This prevents backet matching, code commenting, and other editor features from working properly for the language within the code block

Proposed fix
Register embeddedLanguages for markdown to map fenced code block language scopes back to the correct language mode
@mjbvz mjbvz added the markdown Markdown support issues label Sep 18, 2017
@mjbvz mjbvz added this to the September 2017 milestone Sep 18, 2017
@mjbvz mjbvz self-assigned this Sep 18, 2017
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Sep 18, 2017
@mjbvz mjbvz closed this as completed in b45a168 Sep 18, 2017
@mjbvz
Copy link
Contributor Author

mjbvz commented Sep 18, 2017

To test / verify this, try creating markdown fenced code blocks of various languages and ensure that features like bracket matching and code commenting use the embedded language's configuration rather than the generic markdown language configuration

@roblourens roblourens added the verified Verification succeeded label Sep 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
2 participants
@roblourens @mjbvz