@sandy081 Is your tool ready to check on usages of this?

cc @bpasero, @dbaeumer

+1 for changing the default behaviour and adding that option for the current behaviour.

@jrieken Not yet. Will be ready by tomorrow.

+1 for changing this.

@aeschli and I once had a discussion how to provide this in the LSP (which we didn't at the end) and one idea was that getWorkspaceFolder returns the folder if called with one and that we have a second method getParentWorkspaceFolders which returns an array of all parent folders. The idea was that if I am interested in nesting I am very likely interested in all parents or the top most parent. That would avoid having a flag and looping.

I went through the list of extensions using this and how they use it. I was not able to find the sources of two but all the others use getWorkspaceFolder with a document-uri. That means they won't be affected by the planned change.

This is what I am planning to do (when being called with a workspace folder)

1. Return workspace folder if uri points to a workspace folder and if resolveParent is falsy
2. Return undefined or parent workspace folder if uri points to a workspace folder and if resolveParent is true (to today behaviour)

Update: made this more simple, in the spirit of #34843 (comment) and removed the "return parent workspace folder" semantics

export function getWorkspaceFolder(uri: Uri): WorkspaceFolder | undefined;

Makes sense, though the name resolveParent implies to me that there is some actual work behind it (even though its not), maybe a better name could be found.

Yeah, nuked the parent-stuff all together