Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[seti] Incorrect icon colors in explorer when using Light themes #34850

Closed
bobbrow opened this issue Sep 22, 2017 · 1 comment
Closed

[seti] Incorrect icon colors in explorer when using Light themes #34850

bobbrow opened this issue Sep 22, 2017 · 1 comment
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug icon-brand VS Code brand icon issues themes Color theme issues verified Verification succeeded
Milestone
September 2017

Comments

@bobbrow
Copy link
Member

bobbrow commented Sep 22, 2017

  • VSCode Version: Code 1.16.1 (27492b6, 2017-09-14T16:38:23.027Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
EditorConfig Edi 0.10.1
cpptools ms- 0.13.0
cmake-tools vec 0.10.2

Steps to Reproduce:

  1. Open a folder with a .bat, .xls, or .doc (which have distinguishable colors for their icons)
    • they can be empty files, you just need to get the extension in the filename
  2. Switch the theme from Dark+ to Light+
  3. Notice that the icons are the wrong colors in the Light+ theme. (could be a BGR <-> RGB swizzle problem)
    • Windows & Word should be blue. Excel should be green.

Reproduces without extensions: Yes

dark
light
@ramya-rao-a ramya-rao-a added the icon-brand VS Code brand icon issues label Sep 22, 2017
@bpasero bpasero assigned aeschli and unassigned bpasero Sep 23, 2017
@aeschli aeschli changed the title Incorrect icon colors in explorer when using Light themes [set] Incorrect icon colors in explorer when using Light themes Sep 25, 2017
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug themes Color theme issues labels Sep 25, 2017
@aeschli aeschli added this to the September 2017 milestone Sep 25, 2017
@aeschli
Copy link
Contributor

aeschli commented Sep 25, 2017 •
edited

The Seti theme has defined the colors for dark themes. For the light theme we just invert the colors to ensure the contrast. Changing to darken it instead.

@aeschli aeschli changed the title [set] Incorrect icon colors in explorer when using Light themes [seti] Incorrect icon colors in explorer when using Light themes Sep 25, 2017
@mjbvz mjbvz added the verified Verification succeeded label Sep 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug icon-brand VS Code brand icon issues themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
5 participants
@bpasero @aeschli @bobbrow @mjbvz @ramya-rao-a