Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syntax highlighting for deleted lines in inline diff editor #34855

Closed
felixfbecker opened this issue Sep 22, 2017 · 0 comments
Closed

Add syntax highlighting for deleted lines in inline diff editor #34855

felixfbecker opened this issue Sep 22, 2017 · 0 comments
Assignees
@alexdima
Labels
diff-editor Diff editor mode issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2018

Comments

@felixfbecker
Copy link
Contributor

felixfbecker commented Sep 22, 2017 •
edited by alexdima

  • VSCode Version: Code 1.16.1 (27492b6, 2017-09-14T16:24:39.530Z)
  • OS Version: Darwin x64 16.7.0

Steps to Reproduce:

  1. Open a diff in inline view with deleted lines
  2. See syntax highlighting does work

Example:

image

Reproduces without extensions: Yes/No
@ramya-rao-a ramya-rao-a added the diff-editor Diff editor mode issues label Sep 23, 2017
@alexdima alexdima added the feature-request Request for new features or functionality label Sep 25, 2017
@alexdima alexdima added this to the On Deck milestone Sep 25, 2017
@alexdima alexdima changed the title No syntax highlighting in diff view on deleted lines Add syntax highlighting for deleted lines in inline diff editor Apr 27, 2018
@alexdima alexdima modified the milestones: On Deck, May 2018 Apr 27, 2018
alexdima added a commit that referenced this issue Apr 27, 2018
@alexdima
Fixes #34855: Add syntax highlighting for deleted lines in inline dif…
02fd1aa 
…f editor
@alexdima alexdima added the verification-needed Verification of issue is requested label May 29, 2018
@roblourens roblourens added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
diff-editor Diff editor mode issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
4 participants
@roblourens @alexdima @felixfbecker @ramya-rao-a