Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default name for showSaveDialog when using filters is wrong #35063

Closed
joaomoreno opened this issue Sep 26, 2017 · 2 comments
Closed

Default name for showSaveDialog when using filters is wrong #35063

joaomoreno opened this issue Sep 26, 2017 · 2 comments
Assignees
@jrieken
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2017

Comments

@joaomoreno
Copy link
Member

Testing #34821 on macOS

I call the API so:

window.showSaveDialog({ filters: { 'TypeScript': ['*.ts'] }});

image
@jrieken jrieken added api bug Issue identified by VS Code Team member as probable bug labels Sep 26, 2017
@jrieken
Copy link
Member

jrieken commented Sep 26, 2017

Again, just forward stuff to our service/electron....

@jrieken jrieken added this to the September 2017 milestone Sep 26, 2017
@jrieken
Copy link
Member

jrieken commented Sep 27, 2017

Hm, this is just bad documentation. If you use 'ts' instead of '*.ts' everything works as expected. I'll update the docs

@jrieken jrieken mentioned this issue Sep 27, 2017
Closed
@octref octref added the verified Verification succeeded label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @octref