Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regions are not folding correctly in off-side languages #35091

Closed
sandy081 opened this issue Sep 26, 2017 · 2 comments
Closed

Regions are not folding correctly in off-side languages #35091

sandy081 opened this issue Sep 26, 2017 · 2 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verified Verification succeeded
Milestone
September 2017

Comments

@sandy081
Copy link
Member

Testing #34989

Look at the video. There are total 4 regions with an addition end region line

  • First region is folding correctly
  • All others are not

kapture 2017-09-26 at 14 02 14
@aeschli aeschli added this to the September 2017 milestone Sep 27, 2017
@aeschli
Copy link
Contributor

aeschli commented Sep 28, 2017

Thanks @sandy081. Always post the sample as well... Saves me some typing :-)

Problem is that f# is using the off-side rule where empty lines are treated special
Reproduced with

//#region 
//#endregion

here is a region

//#region 

//#region 

//#region 

//#endregion


//#endregion


//#endregion

//#endregion
``

@aeschli aeschli changed the title Regions are not folding correctly Regions are not folding correctly in off-side languages Sep 28, 2017
@aeschli aeschli added editor-folding Editor code folding issues bug Issue identified by VS Code Team member as probable bug labels Sep 28, 2017
@sandy081
Copy link
Member Author

Thanks for posting the sample. Will save my time for verification :)

@roblourens roblourens added the verified Verification succeeded label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@roblourens @aeschli @sandy081