Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate ctor arguments #35112

Closed
jrieken opened this issue Sep 26, 2017 · 0 comments
Closed

validate ctor arguments #35112

jrieken opened this issue Sep 26, 2017 · 0 comments
Assignees
@bpasero
Labels
api
Milestone
September 2017

Comments

@jrieken
Copy link
Member

jrieken commented Sep 26, 2017

re #34831

When creating an invalid relative pattern we should check the arguments throw if they are invalid, new vscode.RelativePattern('*.ts', undefined); or new vscode.RelativePattern(42);
@jrieken jrieken self-assigned this Sep 26, 2017
@vscodebot vscodebot bot added the api label Sep 26, 2017
@jrieken jrieken assigned bpasero and unassigned jrieken Sep 26, 2017
@bpasero bpasero added this to the September 2017 milestone Sep 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
api
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
2 participants
@bpasero @jrieken