Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick pick fails on umlaut #35125

Closed
jrieken opened this issue Sep 26, 2017 · 9 comments
Closed

quick pick fails on umlaut #35125

jrieken opened this issue Sep 26, 2017 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@jrieken
Copy link
Member

jrieken commented Sep 26, 2017

  • have a workspace called 'wörkspace', use it
  • open an new window, hit Cmd+R for the list of recent workspaces
  • type
  • 🐛 the 'wörkspace'-workspace is removed from the list which is false

sep-26-2017 15-44-27

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2017
@bpasero bpasero added this to the September 2017 milestone Sep 26, 2017
@bpasero
Copy link
Member

bpasero commented Sep 28, 2017

@jrieken good catch, this is another variant of the unicode normalization issue on macOS: the OS will return umlauts as 2 unicode characters (o and :) whereas you as a user type it as one character ö. We already have code here to normalize when we receive paths from the OS which typically only happens when using fs.readdir.

I missed to add this to the native Electron file dialogs (namely showOpenDialog and showSaveDialog) and added it.

Since we put some of the paths for workspaces in a JSON file, they will still have the wrong form so to verify please try with a new workspace. I do not think it would make sense to migrate existing workspaces to NFC form given this feature has not yet hit stable.

@octref octref added the verified Verification succeeded label Sep 28, 2017
@jrieken
Copy link
Member Author

jrieken commented Sep 29, 2017

I still see this with 5d79ec8e56843b6b540a997fd1263a2ceb13d0d2

sep-29-2017 09-46-05

@jrieken jrieken reopened this Sep 29, 2017
@jrieken jrieken removed the verified Verification succeeded label Sep 29, 2017
@bpasero
Copy link
Member

bpasero commented Sep 29, 2017

@jrieken from the gif it looks as if you are able to type "o" followed by ":", are you intentionally triggering this version of the umlaut or is this coming in via normal typing?

@jrieken
Copy link
Member Author

jrieken commented Sep 29, 2017

Well, I have a US-keyboard, so I need to type Alt+u and o for an ö. However, when I paste into the input-field then it doesn't work either

@bpasero
Copy link
Member

bpasero commented Sep 29, 2017

@jrieken was this a workspace you maybe added before my fix, which would indicate that the name contains the decomposed form (o + :). To make sure that is not the case, can you:

  • remove the entry from the recent list
  • open it again via File > Open Workspace
  • in the recently opened make sure to type the ö as single character e.g. via copy paste, see if that works
  • and then once again try with typing it in the decomposed form (o + :)

I would actually expect the first one to find it and the second to not find it. To be fair I would have never expected the second form to find it, even in stable because we are not doing any normalisation in the picker. And frankly speaking, there may be many more places where this hits us.

@jrieken
Copy link
Member Author

jrieken commented Sep 29, 2017

Yeah, that did it.

@bpasero
Copy link
Member

bpasero commented Sep 29, 2017

@jrieken ok, does it also find it when you type ö via your Alt+u and o?

@jrieken
Copy link
Member Author

jrieken commented Sep 29, 2017

Yeah, I guess the history has the old format stored and doesn't normalise what it reads. But I'd say that is fair enough

@bpasero
Copy link
Member

bpasero commented Sep 29, 2017

@jrieken yeah exactly, I did not bother doing a migration of that old format. Closing then as it seems ok once the new format is used.

@bpasero bpasero closed this as completed Sep 29, 2017
@jrieken jrieken added the verified Verification succeeded label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants