-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quick pick fails on umlaut #35125
Comments
@jrieken good catch, this is another variant of the unicode normalization issue on macOS: the OS will return umlauts as 2 unicode characters ( I missed to add this to the native Electron file dialogs (namely Since we put some of the paths for workspaces in a JSON file, they will still have the wrong form so to verify please try with a new workspace. I do not think it would make sense to migrate existing workspaces to NFC form given this feature has not yet hit stable. |
@jrieken from the gif it looks as if you are able to type "o" followed by ":", are you intentionally triggering this version of the umlaut or is this coming in via normal typing? |
Well, I have a US-keyboard, so I need to type Alt+u and o for an ö. However, when I paste |
@jrieken was this a workspace you maybe added before my fix, which would indicate that the name contains the decomposed form (
I would actually expect the first one to find it and the second to not find it. To be fair I would have never expected the second form to find it, even in stable because we are not doing any normalisation in the picker. And frankly speaking, there may be many more places where this hits us. |
Yeah, that did it. |
@jrieken ok, does it also find it when you type |
Yeah, I guess the history has the old format stored and doesn't normalise what it reads. But I'd say that is fair enough |
@jrieken yeah exactly, I did not bother doing a migration of that old format. Closing then as it seems ok once the new format is used. |
Cmd+R
for the list of recent workspaceswö
The text was updated successfully, but these errors were encountered: