Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing workspace file from within workspace doesn't really work #35131

Closed
weinand opened this issue Sep 26, 2017 · 3 comments
Closed

Editing workspace file from within workspace doesn't really work #35131

weinand opened this issue Sep 26, 2017 · 3 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone
September 2017

Comments

@weinand
Copy link
Contributor

weinand commented Sep 26, 2017 •
edited

  • VSCode Version: 1.17 a5210bc
  • OS Version: macOS

While testing #29871:

  • open a multi root workspace
  • open the workspace file as file (in order to add folder names)

Observe:

  • the contents is greyed but it is possible to edit a little bit, e.g. I could add ,"name":"other" but whitespace (newlines, spaces) wouldn't work.
  • the edited file is saved, but the changes are not picked up by VS Code.
  • after a "Reload window" the new folder names showed up correctly
@weinand weinand added bug Issue identified by VS Code Team member as probable bug workbench labels Sep 26, 2017
@weinand weinand mentioned this issue Sep 26, 2017
Closed
@bpasero
Copy link
Member

bpasero commented Sep 26, 2017

@sandy081 this is a missing event we need to add to react to changes

@bpasero bpasero assigned sandy081 and unassigned bpasero Sep 26, 2017
@sandy081 sandy081 added the workbench-multiroot Multi-root (multiple folders) issues label Sep 27, 2017
@sandy081 sandy081 added this to the September 2017 milestone Sep 27, 2017
@sandy081
Copy link
Member

@bpasero I am re-using the existing event onDidChangeWorkspaceFolders for this. Event sends IWorkspaceFoldersChangeEvent that has added, removed and changed workspace folders.

  • Added contains newly added folders
  • Remove contains removed ones
  • Changed contains current changed folders (name)

@bpasero
Copy link
Member

bpasero commented Sep 27, 2017

@sandy081 sounds ok to me, just maybe quickly verify that all listeners of onDidChangeWorkspaceFolders are properly handling this event. E.g not sure everyone is looking at the event specifically.

@bpasero bpasero added the verified Verification succeeded label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@bpasero @weinand @sandy081