Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# folding error #3559

Closed
laimonas opened this issue Feb 29, 2016 · 5 comments
Closed

C# folding error #3559

laimonas opened this issue Feb 29, 2016 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@laimonas
Copy link

Windows 10
untitled

@joaomoreno
Copy link
Member

Codelens rendering cheese

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Mar 1, 2016
@alexdima
Copy link
Member

alexdima commented Mar 1, 2016

@aeschli It is not clear to me what I should do -- should I try to hide all content widgets inside hidden areas?

@aeschli
Copy link
Contributor

aeschli commented Mar 1, 2016

@alexandrudima Looking at the other use cases of the ContentWidget (hover, parameter hints, lightbulb, rename, suggest), it seems to me that a content widget attached to a hidden position should never be shown.

Alternately we could add an API to ask for hidden lines. The code lense could skip the computation and visualization of hidden elements. We would also need a hidden lines event listener.

@chrisdias
Copy link
Member

@alexandrudima this looks bad, do we need to fix for Feb 2016 release?

@chrisdias chrisdias added this to the Feb 2016 milestone Mar 1, 2016
@chrisdias
Copy link
Member

also note that when i fold and unfold all the code lenses are not being restored to the correct location, resulting in overlap with comments (in the case below, in the picture) and phantom blank lines.

image

@alexdima alexdima added important Issue identified as high-priority stable-candiate labels Mar 2, 2016
alexdima added a commit that referenced this issue Mar 2, 2016
@alexdima alexdima assigned aeschli and unassigned alexdima Mar 21, 2016
@aeschli aeschli added the verified Verification succeeded label Mar 21, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants