Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Some projects have trouble loading" error makes viewport smaller than entire editor #3574

Closed
Tyriar opened this issue Mar 1, 2016 · 10 comments
Closed

"Some projects have trouble loading" error makes viewport smaller than entire editor #3574

Tyriar opened this issue Mar 1, 2016 · 10 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
Feb 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 1, 2016

Notice right down the bottom and the top:

image

To get in this state I loaded a folder that had an old C# project in it with tools version 12. It gave me an error at the top, so I opened and read it. Then I tried to close the file by middle clicking the file name up the top which entered the cursor scroll mode, allowing me to scroll the editor down. I did this immediately after installing C# (OmniSharp) on the latest Insiders build on Windows 10.

Here is the output that caused the issue:

[INFO] Starting OmniSharp at 'c:\Users\Daniel\Documents\dev\image-converter\ImageConverter.sln'...
[INFO] Started OmniSharp from 'C:\Users\Daniel\.vscode-insiders\extensions\ms-vscode.csharp-0.3.3\bin\omnisharp.cmd' with process id 3268...
[INFORMATION:OmniSharp.Startup] Omnisharp server running using stdio at location 'c:\Users\Daniel\Documents\dev\image-converter' on host 5004.
[ERROR:OmniSharp.Dnx.DnxPaths] The specified runtime path 'default' does not exist. Searched locations C:\Users\Daniel\.dnx\runtimes\dnx-clr-win-x86.default
C:\Users\Daniel\.dnx\runtimes\kre-clr-win-x86.default
C:\Users\Daniel\.dnx\packages\KRE-CLR-x86.default
C:\Users\Daniel\.k\runtimes\dnx-clr-win-x86.default
C:\Users\Daniel\.k\runtimes\kre-clr-win-x86.default
C:\Users\Daniel\.k\packages\KRE-CLR-x86.default
C:\Users\Daniel\.kre\runtimes\dnx-clr-win-x86.default
C:\Users\Daniel\.kre\runtimes\kre-clr-win-x86.default
C:\Users\Daniel\.kre\packages\KRE-CLR-x86.default.
Visit https://github.com/aspnet/Home for an installation guide.
[INFORMATION:OmniSharp.Dnx.DnxProjectSystem] Scanning 'c:\Users\Daniel\Documents\dev\image-converter' for DNX projects
[INFORMATION:OmniSharp.Dnx.DnxProjectSystem] No project.json based projects found
[INFORMATION:OmniSharp.MSBuild.MSBuildProjectSystem] Detecting projects in 'c:\Users\Daniel\Documents\dev\image-converter\ImageConverter.sln'.
[INFORMATION:OmniSharp.MSBuild.MSBuildProjectSystem] Loading project from 'c:\Users\Daniel\Documents\dev\image-converter\ImageConverter\ImageConverter.csproj'.
[INFORMATION:OmniSharp.MSBuild.MSBuildProjectSystem] Using toolset 2.0 for c:\Users\Daniel\Documents\dev\image-converter\ImageConverter\ImageConverter.csproj
[WARNING:OmniSharp.MSBuild.MSBuildProjectSystem] Failed to process project file 'c:\Users\Daniel\Documents\dev\image-converter\ImageConverter\ImageConverter.csproj'.
Microsoft.Build.Exceptions.InvalidProjectFileException: The tools version "12.0" is unrecognized. Available tools versions are "14.0", "2.0", "3.5", "4.0".  c:\Users\Daniel\Documents\dev\image-converter\ImageConverter\ImageConverter.csproj
   at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject(String errorSubCategoryResourceName, IElementLocation elementLocation, String resourceName, Object[] args)
   at Microsoft.Build.Evaluation.Project.Data.InitializeForEvaluation(IToolsetProvider toolsetProvider)
   at Microsoft.Build.Evaluation.Evaluator`4..ctor(IEvaluatorData`4 data, ProjectRootElement projectRootElement, ProjectLoadSettings loadSettings, Int32 maxNodeCount, PropertyDictionary`1 environmentProperties, ILoggingService loggingService, IItemFactory`2 itemFactory, IToolsetProvider toolsetProvider, ProjectRootElementCache projectRootElementCache, BuildEventContext buildEventContext, ProjectInstance projectInstanceIfAnyForDebuggerOnly)
   at Microsoft.Build.Evaluation.Evaluator`4.Evaluate(IEvaluatorData`4 data, ProjectRootElement root, ProjectLoadSettings loadSettings, Int32 maxNodeCount, PropertyDictionary`1 environmentProperties, ILoggingService loggingService, IItemFactory`2 itemFactory, IToolsetProvider toolsetProvider, ProjectRootElementCache projectRootElementCache, BuildEventContext buildEventContext, ProjectInstance projectInstanceIfAnyForDebuggerOnly)
   at Microsoft.Build.Evaluation.Project.ReevaluateIfNecessary(ILoggingService loggingServiceForEvaluation)
   at Microsoft.Build.Evaluation.Project.Initialize(IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectLoadSettings loadSettings)
   at Microsoft.Build.Evaluation.Project..ctor(String projectFile, IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectCollection projectCollection, ProjectLoadSettings loadSettings)
   at Microsoft.Build.Evaluation.ProjectCollection.LoadProject(String fileName, IDictionary`2 globalProperties, String toolsVersion)
   at OmniSharp.MSBuild.ProjectFile.ProjectFileInfo.Create(MSBuildOptions options, ILogger logger, String solutionDirectory, String projectFilePath, ICollection`1 diagnostics)
   at OmniSharp.MSBuild.MSBuildProjectSystem.CreateProject(String projectFilePath)
c:\Users\Daniel\Documents\dev\image-converter\ImageConverter\ImageConverter.csproj(0,0)
Microsoft.Build.Exceptions.InvalidProjectFileException: The tools version "12.0" is unrecognized. Available tools versions are "14.0", "2.0", "3.5", "4.0".  c:\Users\Daniel\Documents\dev\image-converter\ImageConverter\ImageConverter.csproj
   at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject(String errorSubCategoryResourceName, IElementLocation elementLocation, String resourceName, Object[] args)
   at Microsoft.Build.Evaluation.Project.Data.InitializeForEvaluation(IToolsetProvider toolsetProvider)
   at Microsoft.Build.Evaluation.Evaluator`4..ctor(IEvaluatorData`4 data, ProjectRootElement projectRootElement, ProjectLoadSettings loadSettings, Int32 maxNodeCount, PropertyDictionary`1 environmentProperties, ILoggingService loggingService, IItemFactory`2 itemFactory, IToolsetProvider toolsetProvider, ProjectRootElementCache projectRootElementCache, BuildEventContext buildEventContext, ProjectInstance projectInstanceIfAnyForDebuggerOnly)
   at Microsoft.Build.Evaluation.Evaluator`4.Evaluate(IEvaluatorData`4 data, ProjectRootElement root, ProjectLoadSettings loadSettings, Int32 maxNodeCount, PropertyDictionary`1 environmentProperties, ILoggingService loggingService, IItemFactory`2 itemFactory, IToolsetProvider toolsetProvider, ProjectRootElementCache projectRootElementCache, BuildEventContext buildEventContext, ProjectInstance projectInstanceIfAnyForDebuggerOnly)
   at Microsoft.Build.Evaluation.Project.ReevaluateIfNecessary(ILoggingService loggingServiceForEvaluation)
   at Microsoft.Build.Evaluation.Project.Initialize(IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectLoadSettings loadSettings)
   at Microsoft.Build.Evaluation.Project..ctor(String projectFile, IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectCollection projectCollection, ProjectLoadSettings loadSettings)
   at Microsoft.Build.Evaluation.ProjectCollection.LoadProject(String fileName, IDictionary`2 globalProperties, String toolsVersion)
   at OmniSharp.MSBuild.ProjectFile.ProjectFileInfo.Create(MSBuildOptions options, ILogger logger, String solutionDirectory, String projectFilePath, ICollection`1 diagnostics)
   at OmniSharp.MSBuild.MSBuildProjectSystem.CreateProject(String projectFilePath)

[INFORMATION:OmniSharp.ScriptCs.ScriptCsProjectSystem] Detecting CSX files in 'c:\Users\Daniel\Documents\dev\image-converter'.
[INFORMATION:OmniSharp.ScriptCs.ScriptCsProjectSystem] Could not find any CSX files
[INFORMATION:OmniSharp.Startup] Solution has finished loading
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Mar 1, 2016
@bpasero
Copy link
Member

bpasero commented Mar 1, 2016

@Tyriar can you inspect what HTML element the message is in DOM? I suspect the middle mouse scrolling revealed it somehow.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 1, 2016 

<div class="alert" role="alert" aria-atomic="true">Warning: Some projects have trouble loading. Please review the output for more details.</div>

Inside body > div.aria-container

@bpasero bpasero added this to the March 2016 milestone Mar 1, 2016
@bpasero bpasero self-assigned this Mar 1, 2016
@bpasero
Copy link
Member

bpasero commented Mar 1, 2016

Thanks, I suspected that one.

@bpasero bpasero modified the milestones: Feb 2016, March 2016 Mar 1, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Mar 1, 2016

Adding left: -999em to .aria-container will correctly take it out of the page flow.

@bpasero
Copy link
Member

bpasero commented Mar 1, 2016

Yeah, something like that. We still have to ensure a screen reader picks it up.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 1, 2016

Yep, sending it off screen should still be read out by the screen reader.

@bpasero bpasero closed this as completed in 5350b1d Mar 1, 2016
@bpasero bpasero assigned Tyriar and unassigned bpasero Mar 1, 2016
@Tyriar Tyriar mentioned this issue Mar 1, 2016
Closed
@isidorn
Copy link
Contributor

isidorn commented Mar 2, 2016

@Tyriar please verify until end of week since this is a stable-candidate

bpasero added a commit that referenced this issue Mar 2, 2016
@bpasero
"Some projects have trouble loading" error makes viewport smaller tha…
3c310f4 
…n entire editor (fixes #3574)
@Tyriar
Copy link
Member Author

Tyriar commented Mar 3, 2016

Not working in latest alpha with the changes, it's even worse:

image

Verified again in devtools, left:-999em; takes it out of the flow of the page.

@Tyriar Tyriar reopened this Mar 3, 2016
@Tyriar Tyriar assigned bpasero and unassigned Tyriar Mar 3, 2016
bpasero added a commit that referenced this issue Mar 3, 2016
@bpasero
"Some projects have trouble loading" error makes viewport smaller tha…
eef9fa0 
…n entire editor (fixes #3574)
@bpasero
Copy link
Member

bpasero commented Mar 3, 2016

@Tyriar ok I pushed a change with your suggestion to stable, can you please verify again?

@bpasero bpasero closed this as completed Mar 3, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Mar 3, 2016

Fixed 👍

@Tyriar Tyriar added the verified Verification succeeded label Mar 3, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
Feb 2016
Development

No branches or pull requests
3 participants
@bpasero @isidorn @Tyriar