Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Clear Recently Opened" should also clear editor quick pick history #35935

Closed
axefrog opened this issue Oct 9, 2017 · 6 comments
Closed

"Clear Recently Opened" should also clear editor quick pick history #35935

axefrog opened this issue Oct 9, 2017 · 6 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2018

Comments

@axefrog
Copy link

axefrog commented Oct 9, 2017

  • VSCode Version: 1.17.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open a file to get it into quick open's "recently opened" suggestions
  2. Close the file
  3. Press CTRL+P; start typing the filename and it should show up with the label "recently opened"
  4. Bring up the command bar and select "clear recently opened"
  5. The file is gone from the file menu's recently opened files, but not from the quick open bar

vscode-clear-recently-opened

I understand that the command bar's recently opened suggestions are a separate feature to the recent files list in the file menu, but I'd say that:

  1. They may be separate in terms of implementation, but they are probably the same from the user's perspective. Clearing one should probably clear the other.
  2. Even if they stay separate, the nomenclature should be changed - the hint text displayed to the right of the file in quick open is "recently opened"; providing a "clear recently opened" command creates confusion, given that the latter has no effect on the former.
@vscodebot vscodebot bot added the new release label Oct 9, 2017
@vscodebot vscodebot bot added the workbench label Oct 9, 2017
@axefrog axefrog changed the title Confusing relationship between "clear recently opened" and quick open's "recently opened" label Confusing relationship between "clear recently opened" and quick open's "recently opened" hint text Oct 9, 2017
@sandy081 sandy081 assigned bpasero and unassigned sandy081 Oct 10, 2017
@bpasero bpasero changed the title Confusing relationship between "clear recently opened" and quick open's "recently opened" hint text "Clear Recently Opened" should also clear editor quick pick history Oct 11, 2017
@bpasero bpasero added feature-request Request for new features or functionality quick-pick Quick-pick widget issues labels Oct 11, 2017
@bpasero bpasero removed their assignment Oct 11, 2017
@bpasero bpasero removed the workbench label Nov 16, 2017
@indfnzo
Copy link

indfnzo commented Apr 4, 2018 •
edited

Would love this feature! This always bites me when I rename a folder and all the Ctrl+P results fire a File Not Found error.

As a workaround though, the solution from #3260 (comment) works for me.

@raynicho raynicho mentioned this issue Apr 6, 2018
Closed
@bpasero
Copy link
Member

bpasero commented Apr 6, 2018 •
edited

It is easily possible to clear the editor history of Cmp+P, just use this:

image

You can even remove individual entries:

image

@bpasero bpasero self-assigned this Sep 12, 2018
@bpasero bpasero added this to the September 2018 milestone Sep 12, 2018
@bpasero bpasero added the verification-needed Verification of issue is requested label Sep 12, 2018
@bpasero
Copy link
Member

bpasero commented Sep 12, 2018

Picking "Clear Recently Opened" will now also remove "recently used" from the picker.

@isidorn
Copy link
Contributor

isidorn commented Sep 25, 2018

@bpasero I verified that the Clear Editor History and remove from history properly remove editors from the quick pick history.
However clicking on Clear Recently Opened in the menu does not modify the quick open editor history. Should I reopen?

@bpasero
Copy link
Member

bpasero commented Sep 25, 2018

@isidorn good catch

@bpasero bpasero reopened this Sep 25, 2018
@isidorn isidorn added the verified Verification succeeded label Sep 26, 2018
@schoening
Copy link

Looks like "Clear Editor History" first becomes active on a reload? Perhaps something worth changing, that or force reload the editor. Unless I am wrong and it's only my version that does not show the changes instantly :)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

Successfully merging a pull request may close this issue.

"Clear Recently Opened" now clears editor history raynicho/vscode
7 participants
@axefrog @bpasero @isidorn @schoening @indfnzo @chrmarti @sandy081