Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

languages.filenamePatterns is ignored #3594

Closed
alexdima opened this issue Mar 1, 2016 · 2 comments
Closed

languages.filenamePatterns is ignored #3594

alexdima opened this issue Mar 1, 2016 · 2 comments
Assignees
@jrieken
Labels
api bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
Feb 2016

Comments

@alexdima
Copy link
Member

alexdima commented Mar 1, 2016

When contributing a language, it is possible to specify filenamePatterns.

The property gets lost and not used in determining the language when opening a file.


  "contributes": {
      "languages": [
          {
              "id": "dockerfile",
              "aliases": [
                  "Dockerfile"
              ],
              "filenamePatterns": [
                  "dockerfile.*",
                  "Dockerfile*.*"
              ]
          }
      ],
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug api stable-candiate labels Mar 1, 2016
@alexdima alexdima added this to the March 2016 milestone Mar 1, 2016
@alexdima alexdima added the important Issue identified as high-priority label Mar 1, 2016
@alexdima alexdima modified the milestones: Feb 2016, March 2016 Mar 1, 2016
@alexdima alexdima self-assigned this Mar 1, 2016
@bpasero
Copy link
Member

bpasero commented Mar 1, 2016

@alexandrudima interesting, I think I reported this to @jrieken in #2333 (comment) because I had this as test item.

@chrisdias
Copy link
Member

ping @alexandrudima ... don't forget to check this in for Feb!!! :)

alexdima added a commit that referenced this issue Mar 7, 2016
@alexdima
Fixes #3594: copy over filenamePatterns when validating language exte…
5b5f4db 
…nsion point
@alexdima alexdima assigned jrieken and unassigned alexdima Mar 21, 2016
@jrieken jrieken added the verified Verification succeeded label Mar 21, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
Feb 2016
Development

No branches or pull requests
4 participants
@bpasero @chrisdias @jrieken @alexdima