-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune the extension tips appearance in status bar #3633
Comments
It is still not clear to me how this should work. Currently it behaves this way:
Now, I can take that 28-days-memento out, but still... what would happen to the widget when clicked? Would it go away? Why, and when would it come back? |
I think we should remove the 28days memento, but let's go through a scenario:
|
I don't like the idea of the notification in the status bar coming and going. I end up playing games trying to figure out how to make it come back again. What if i pressed Enter to install one of the four extensions listed (instead of clicking the download button) and now I want to install another one? If the status bar indicator is gone how do I get it back? I don't know that i can go to the command palette and choose "Extension Tips"... if I did I wouldn't need this status bar indicator at all! Related, if we remove items from the list because I didn't install them the first time I saw them, how would I get them back? Here is how I see the scenario:
Assume there are 5 extensions recommended for this workspace (jshint, jscs, tslint, omnisharp, and can i use). Also assume the suggestion icon is always in the status bar given my concerns about trying to figure out how to make it come up again. The user clicks on the icon, gets a list of extensions they could install, and presses Enter on TSLint. The list goes away, the extension is installed, and I restart VSCode. Now, I want to install jshint because i saw that in the list. I go back to the status bar indicator, click on it, and I see 4 items in the list now because I installed TSLint already. I repeat the process, installing jshint and omnisharp.
Knowing that Code gave me extension suggestions before, I can click on the status bar and a list shows up that now includes a PHP extension. I follow the same workflow as above and I install the PHP extension. Ideally we would show a number/badge in the status bar indicating how many extensions are suggested. Maybe in a week a new extension list comes out and there are new opportunities. I could see the badge change to say "1" or "2" and I would click on it to see what's new. If there are updated extensions I could imagine the update extension icon having a badge telling me how many are available. Same with errors. CC @waderyan |
Looks like the only disagreement is whether the I would still like to have an info message in the quick box, that explains what this list is about. The |
Yes, removing the 28 day memento easily comes to the conclusion that that thing is always in your status bar and never goes away... Will just do that for GA: if there are tips, just always show it. Not happy about it though. We definitely need extensions to be a core workbench concept, UI-wise. |
👍 |
@seanmcbreen feel free to add more thoughts here. One suggestion (by @egamma and @seanmcbreen) is to add a small prompt for why these specific extensions are shown. Something like: "Here are extensions that could be useful based on the files in your workspace" (feel free to change that language). |
Conclusion after discussion among @egamma, @joaomoreno, @waderyan, @chrisdias
|
@egamma What about the quick open text. Currently it is |
This will be worked on as part of a holistic improvement to the extension experience in product. |
The extension tips should appear whenever there are new extensions for a user to look at.
The text was updated successfully, but these errors were encountered: