Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On macOS, with editor.find.seedSearchStringFromSelection set to false, command-e doesn't populate search string #36596

Closed
aaptho opened this issue Oct 19, 2017 · 0 comments
Closed

On macOS, with editor.find.seedSearchStringFromSelection set to false, command-e doesn't populate search string #36596

aaptho opened this issue Oct 19, 2017 · 0 comments
Assignees
@rebornix
Labels
editor-find Editor find operations feature-request Request for new features or functionality

Comments

@aaptho
Copy link

aaptho commented Oct 19, 2017

  • VSCode Version: Code 1.17.2 (b813d12, 2017-10-16T13:47:41.889Z)
  • OS Version: Darwin x64 17.0.0
  • Extensions:
Extension Author (truncated) Version
unity-tools Tob 0.1.9
unity-debug Uni 1.2.1
vscode-eslint dba 1.3.2
python don 0.7.0
cpptools ms- 0.14.0
csharp ms- 1.12.1
mono-debug ms- 0.15.7
vscode-arduino vsc 0.2.9

Steps to Reproduce:

  1. Add the user setting
    "editor.find.seedSearchStringFromSelection": false,

  2. Select text in a document

  3. Press command-e

  4. Press command-f

Expected results: VS Code matches the standard Mac text find behavior, where command-e populates the search pasteboard with the current selection, but doesn't show the find panel. Pressing command-f thereafter shows the find panel, revealing what I put in there with command-e.

Actual results: pressing command-e shows the find panel and doesn't populate the search pasteboard

Plx to allow me to match the macOS standard behavior! Is my favest!

Reproduces without extensions: Yes
@vscodebot vscodebot bot added new release editor-find Editor find operations labels Oct 19, 2017
@alexdima alexdima assigned rebornix and unassigned alexdima Oct 21, 2017
@rebornix rebornix added the feature-request Request for new features or functionality label Nov 16, 2017
rebornix added a commit that referenced this issue Nov 22, 2017
@rebornix
Merge pull request #38908 from rebornix/rebornix/36596
55866fc 
Fix #36596. Cmd+e should always populate the search string
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
editor-find Editor find operations feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rebornix @alexdima @aaptho @chrmarti