Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug adapter can't enable ExceptionBreakpointFilters by default #3675

Closed
faxue-msft opened this issue Mar 3, 2016 · 3 comments
Closed

Debug adapter can't enable ExceptionBreakpointFilters by default #3675

faxue-msft opened this issue Mar 3, 2016 · 3 comments
Assignees
@weinand
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Milestone
March 2016

Comments

@faxue-msft
Copy link

Because of some recent changes now debug adapter must provide default ExceptionBreakpointFilters, however there seems to be no way to enabled some or all of these filters by default. It's kind of unexpected for user that the "Unhandled Exceptions" filter is disabled by default.

Related:
#3015 (comment)
c676ceb
@isidorn isidorn self-assigned this Mar 3, 2016
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Mar 3, 2016
@isidorn
Copy link
Contributor

isidorn commented Mar 3, 2016

You are right, currently it is not possible for an adapter to say that an exception breakpoint should be enabled by default.
Forwarding to @weinand to decide if we want to introduce this to the protocol, and if we decide to introduce it then I can add it on the vscode side

@isidorn isidorn assigned weinand and unassigned isidorn Mar 3, 2016
@weinand
Copy link
Contributor

weinand commented Mar 3, 2016

Makes sense. Will try to add this for March.

@weinand weinand added this to the March 2016 milestone Mar 4, 2016
@isidorn isidorn closed this as completed in 022daf9 Mar 4, 2016
weinand added a commit to microsoft/vscode-debugadapter-node that referenced this issue Mar 4, 2016
@weinand
add 'default' attribute to exceptionBreakpointFilters; fixes microsof…
605eedc 
…t/vscode#3675
weinand added a commit to microsoft/vscode-node-debug that referenced this issue Mar 4, 2016
@weinand
use 'default' attribute to exceptionBreakpointFilters; fixes microsof…
c829811 
…t/vscode#3675
weinand added a commit that referenced this issue Mar 4, 2016
@weinand
update node-debug for #3675
575ee25
@weinand weinand added the verified Verification succeeded label Mar 4, 2016
@weinand
Copy link
Contributor

weinand commented Mar 4, 2016

@daviwil @felixfbecker @lukehoban @rkeithhill @gregg-miskelly
you can now control whether an exception filter is enabled or disabled by returning an attribute default for the exceptionBreakpointsFilter capability.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

No branches or pull requests
3 participants
@weinand @isidorn @faxue-msft