Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCSS: Tags nested inside rules are not styled as tags #36923

Closed
smlombardi opened this issue Oct 25, 2017 · 3 comments
Closed

SCSS: Tags nested inside rules are not styled as tags #36923

smlombardi opened this issue Oct 25, 2017 · 3 comments
Assignees
@aeschli
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling

Comments

@smlombardi
Copy link

smlombardi commented Oct 25, 2017 •
edited

  • VSCode Version: Code - Insiders 1.18.0-insider (509630f, 2017-10-25T05:11:41.369Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions:
Extension Author (truncated) Version
code-settings-sync Sha 2.8.3
sort-lines Tyr 1.3.0
html-snippets abu 0.1.0
Bookmarks ale 0.17.0
project-manager ale 0.22.0
vscode-eslint dba 1.4.0
gitlens eam 5.7.1
tslint eg2 1.0.12
vscode-console-wrapper fab 0.4.0
auto-rename-tag for 0.0.14
svg joc 0.0.9
Angular2 joh 2.10.0
ecdc mit 0.10.3
HTMLHint mka 0.4.0
vscode-autoprefixer mrm 2.1.2
vscode-stylefmt mrm 2.5.0
angular2-inline nat 0.0.17
vscode-versionlens pfl 0.19.1
stylelint shi 0.30.0
Align ste 0.2.0
change-case wma 1.0.0

(1 theme extensions excluded)

Steps to Reproduce:

  1. Using code such as
.showcase-modal_overview_header {
  display: flex;
  justify-content: space-between;
  align-items: flex-end;
  margin-bottom: 12px;
  h3 {
    margin: 0 0 -7px;
  }
}
  1. The h3 is not colored as a tag:

screen shot 2017-10-25 at 2 12 52 pm

This is a regression.
@dbaeumer dbaeumer added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Oct 25, 2017
@aeschli aeschli mentioned this issue Oct 26, 2017
Closed
@aeschli
Copy link
Contributor

aeschli commented Oct 26, 2017

This issue was moved to atom/language-sass#237

@aeschli aeschli closed this as completed Oct 26, 2017
@smlombardi
Copy link
Author

@aeschli This looks like it's resolved in atom/language-sass#237

When can we expect this in Code Insiders? It's been a while now, and it makes scss editing more annoying that it needs to be.

@smlombardi smlombardi mentioned this issue Nov 9, 2017
Closed
@aeschli
Copy link
Contributor

aeschli commented Nov 10, 2017

@smlombardi Thanks, I updated the grammar.

aeschli added a commit that referenced this issue Nov 10, 2017
@aeschli
[scss] update grammar (for #36923)
0485928
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smlombardi @dbaeumer @aeschli