Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reviver/replacer is slow #36972

Closed
jrieken opened this issue Oct 26, 2017 · 1 comment
Closed

reviver/replacer is slow #36972

jrieken opened this issue Oct 26, 2017 · 1 comment
Assignees
@jrieken @alexdima
Labels
debt Code quality issues perf
Milestone
January 2018

Comments

@jrieken
Copy link
Member

jrieken commented Oct 26, 2017

We have a reviver and replacer function for the extension host communication that ensure regular expressions and URIs are always what you would expect. This is convenient but also slow because the reviver visits every object. We should manually convert those (as we do with any other type as well)
@jrieken jrieken added the perf label Oct 26, 2017
@jrieken jrieken mentioned this issue Oct 26, 2017
Closed
@jrieken jrieken added this to the November 2017 milestone Oct 26, 2017
@jrieken jrieken added the debt Code quality issues label Nov 13, 2017
@jrieken jrieken modified the milestones: November 2017, December 2017 Dec 1, 2017
jrieken added a commit that referenced this issue Dec 4, 2017
@jrieken
implement custom revive (cuts parse time in half), #36972
5a89b5c
alexdima added a commit that referenced this issue Dec 13, 2017
@alexdima
Mark messages that need reviving (#36972)
fb27807
alexdima added a commit that referenced this issue Dec 13, 2017
@alexdima
Improve shape of RPC messages (#36972)
5761b73
alexdima added a commit that referenced this issue Dec 13, 2017
@alexdima
Allow for messages not using marshalling to flow through rpcProtocol (#…
64375e4 
…36972)
alexdima added a commit that referenced this issue Dec 13, 2017
@alexdima
Simplify RPCProtocol usage (#36972)
068f7bb
alexdima added a commit that referenced this issue Dec 13, 2017
@alexdima
Simplify AbstractThreadService usage (#36972)
252d49c
alexdima added a commit that referenced this issue Dec 13, 2017
@alexdima
Further simplifications (#36972)
0abd821
alexdima added a commit that referenced this issue Dec 13, 2017
@alexdima
Add RPCProtocol.getFastProxy (#36972)
2b4ce13
alexdima added a commit that referenced this issue Dec 13, 2017
@alexdima
Rename RPCProtocol.get to RPCProtocol.getProxy (#36972)
367dd10
alexdima added a commit that referenced this issue Dec 13, 2017
@alexdima
Have the marshalling kind be a property of the proxy identifier (#36972)
bef346d
@alexdima
Copy link
Member

This can be configured per proxy now. Let's track the adoption in #40169

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@alexdima alexdima

Labels
debt Code quality issues perf
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@jrieken @alexdima