Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline changes view has folding actions #37249

Closed
sandy081 opened this issue Oct 31, 2017 · 5 comments
Closed

Inline changes view has folding actions #37249

sandy081 opened this issue Oct 31, 2017 · 5 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verified Verification succeeded
Milestone
November 2017

Comments

@sandy081
Copy link
Member

Testing #37164

screen shot 2017-10-31 at 12 11 21
@vscodebot vscodebot bot added editor editor-folding Editor code folding issues labels Oct 31, 2017
@sandy081 sandy081 removed editor editor-folding Editor code folding issues labels Oct 31, 2017
@sandy081 sandy081 changed the title Inline changes views has folding actions Inline changes view has folding actions Oct 31, 2017
@joaomoreno
Copy link
Member

cc @aeschli

@joaomoreno joaomoreno added this to the October 2017 milestone Nov 1, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Nov 1, 2017
@aeschli
Copy link
Contributor

aeschli commented Nov 1, 2017

The inline diff editor seems to not show the folding gutter annotations. IMO that should happen here too.

@joaomoreno
Copy link
Member

@aeschli And how is that achieved?

@joaomoreno joaomoreno modified the milestones: October 2017, November 2017 Nov 1, 2017
@aeschli
Copy link
Contributor

aeschli commented Nov 1, 2017 •
edited

@alexandrudima Can you help?

@aeschli aeschli added editor-folding Editor code folding issues and removed scm General SCM compound issues labels Nov 10, 2017
@aeschli
Copy link
Contributor

aeschli commented Nov 10, 2017

The problem was that the folding decorations were created on the model, not on the editor.
So the folding icons show up also in editors that have folding turned off.

@joaomoreno joaomoreno mentioned this issue Nov 13, 2017
Closed
@sandy081 sandy081 added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
3 participants
@joaomoreno @aeschli @sandy081