Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing redraw after Fold All #37271

Closed
kieferrm opened this issue Oct 31, 2017 · 6 comments
Closed

Missing redraw after Fold All #37271

kieferrm opened this issue Oct 31, 2017 · 6 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues verified Verification succeeded
Milestone
April 2018

Comments

@kieferrm
Copy link
Member

kieferrm commented Oct 31, 2017 •
edited

While testing #37173.

  • VSCode Version: Code - Insiders 1.18.0-insider (81cca6c, 2017-10-31T05:47:36.947Z)
  • OS Version: Darwin x64 16.7.0

Steps to Reproduce:

  1. Open a large file (I used a js file with 67000 lines).
  2. Put the caret in the last line of the editor.
  3. "Fold All" through the command palette
    -> Editor area including gutters will turn completely white. Redraw happens on scrolling.

Reproduces without extensions: Yes
@vscodebot vscodebot bot added editor editor-folding Editor code folding issues labels Oct 31, 2017
@aeschli
Copy link
Contributor

aeschli commented Nov 1, 2017

I wasn't able to reproduce, neither on OSX nor on Ubuntu (JSON file with 130'000 lines).
Can you point me to the file you used?

@aeschli
Copy link
Contributor

aeschli commented Nov 10, 2017

@kieferrm do you have more information?

@aeschli aeschli added the info-needed Issue requires more information from poster label Nov 10, 2017
@kieferrm
Copy link
Member Author

  1. Open a vs code workspace
  2. Replace src/vs/workbench/browser/editor.ts with this version: editor.ts.zip
  3. Open the editor
  4. Place caret on last line
  5. Cmd+KCmd+1
    -> empty screen

utcvpgo2hd

@aeschli
Copy link
Contributor

aeschli commented Nov 10, 2017

I still can't reproduce, but this looks like a rendering issue.

@aeschli aeschli assigned alexdima and unassigned aeschli Nov 10, 2017
@aeschli aeschli removed the info-needed Issue requires more information from poster label Nov 10, 2017
@alexdima
Copy link
Member

I could not reproduce on Windows, not on stable or on insiders, so it might be mac specific:

I've also tried with "editor.scrollBeyondLastLine": false (it appears that is a setting you have from the gif):

37271

@alexdima alexdima added the macos Issues with VS Code on MAC/OS X label Nov 10, 2017
@alexdima
Copy link
Member

Reproduces with:

    "editor.scrollBeyondLastLine": false,
    "typescript.referencesCodeLens.enabled": true

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug and removed editor labels Nov 24, 2017
@alexdima alexdima added editor-rendering Editor rendering issues and removed editor-folding Editor code folding issues macos Issues with VS Code on MAC/OS X labels Apr 18, 2018
@alexdima alexdima added this to the April 2018 milestone Apr 18, 2018
@mjbvz mjbvz added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
4 participants
@kieferrm @alexdima @aeschli @mjbvz