Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error doesn't disappear automatically after using quick action to install typings #37288

Closed
dbaeumer opened this issue Oct 31, 2017 · 6 comments
Closed

Error doesn't disappear automatically after using quick action to install typings #37288

dbaeumer opened this issue Oct 31, 2017 · 6 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
January 2018

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Oct 31, 2017 •
edited

  • OS Windows
  • ts file
import * as _ from 'lodash';
  • execute action to install typings
  • observe: the error doesn't disappear. You need to change the file / import
@vscodebot vscodebot bot added the typescript Typescript support issues label Oct 31, 2017
@dbaeumer dbaeumer changed the title Errro doesn't disappear automatically after using quick action to install typings Error doesn't disappear automatically after using quick action to install typings Oct 31, 2017
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Nov 10, 2017
@mjbvz mjbvz added this to the November 2017 milestone Nov 16, 2017
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Nov 16, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Nov 16, 2017

Should be fixed upstream: microsoft/TypeScript#19597

@mjbvz mjbvz closed this as completed Nov 16, 2017
@roblourens
Copy link
Member

It's not installing the types at all when I run the action "Install @types/lodash" under the lightbulb. What am I doing wrong?

@roblourens
Copy link
Member

Ping @mjbvz

@mjbvz
Copy link
Contributor

mjbvz commented Dec 7, 2017

Yes, this is broken

@mjbvz mjbvz reopened this Dec 7, 2017
@mjbvz mjbvz closed this as completed in bc206bb Dec 7, 2017
@roblourens
Copy link
Member

roblourens commented Dec 8, 2017 •
edited

@mjbvz I see the same thing now, and should have that commit?

@mjbvz mjbvz reopened this Dec 8, 2017
@mjbvz mjbvz modified the milestones: November 2017, Backlog, December 2017 Dec 8, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Dec 8, 2017 •
edited

Ok, not sure why this worked when I tested it yesterday. Issue is that TS returns this fix as a refactoring instead of a quick fix. Since 1.19 only request refactorings when you have a selection. We also don't apply the commands returned from refactorings. This needs the same change as bc206bb.

Pushing to December because you pretty much can't even trigger the quick fix at the moment due to the first issue. See microsoft/TypeScript#19378 for info about my original request for this to be fixed

//CC @RMacfarlane

@mjbvz mjbvz mentioned this issue Dec 8, 2017
Closed
@mjbvz mjbvz closed this as completed Jan 30, 2018
@octref octref added the verified Verification succeeded label Feb 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@roblourens @dbaeumer @octref @mjbvz