Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taskDefinitions property descriptions are not localized #37565

Closed
mjbvz opened this issue Nov 2, 2017 · 4 comments
Closed

taskDefinitions property descriptions are not localized #37565

mjbvz opened this issue Nov 2, 2017 · 4 comments
Assignees
@dbaeumer
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
February 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 2, 2017

In the typescript extension for example:

    "taskDefinitions": [
      {
        "type": "typescript",
        "required": [
          "tsconfig"
        ],
        "properties": {
          "tsconfig": {
            "type": "string",
            "description": "The tsconfig file that defines the TS build"
          },
          "option": {
            "type": "string"
          }
        }
      }
    ],

The tsconfig property's description field is not localized. Seems to be true for all taskDefinitions in the builtin extensions
@dbaeumer dbaeumer added this to the November 2017 milestone Nov 3, 2017
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Nov 3, 2017
@dbaeumer dbaeumer modified the milestones: November 2017, January 2018 Dec 4, 2017
@dbaeumer
Copy link
Member

dbaeumer commented Dec 4, 2017

Not critical. Moving to next milestone.

@alexdima alexdima modified the milestones: February 2018, December 2017 Dec 12, 2017
@ramya-rao-a
Copy link
Contributor

@dbaeumer Is this still for January or can we move it to Feb?

@dbaeumer
Copy link
Member

dbaeumer commented Feb 1, 2018

I planned to but I was busy tracking down the startup performance problem. Will move.

@dbaeumer dbaeumer modified the milestones: January 2018, February 2018 Feb 1, 2018
@dbaeumer
Copy link
Member

dbaeumer commented Mar 1, 2018

I did gulp, grunt, jake. npm is done as well. Did TS as well.

@tsalinger tsalinger added the verified Verification succeeded label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
5 participants
@dbaeumer @alexdima @mjbvz @tsalinger @ramya-rao-a