Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension's keybinding error: "property key is mandatory" #37679

Closed
fabiospampinato opened this issue Nov 5, 2017 · 0 comments
Closed

Extension's keybinding error: "property key is mandatory" #37679

fabiospampinato opened this issue Nov 5, 2017 · 0 comments
Assignees
@alexdima
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Milestone
September 2018

Comments

@fabiospampinato
Copy link
Contributor

I'm writing an extension that contributes a keybinding, since it only supports macOS I've set the mac property that defines the shortcut for macOS, and I didn't set the key property that defines the shortcut for other systems, which are not supported anyway.

VSC is complaining about this with the "property key is mandatory" error.

Am I supposed to set the key property anyway and just warn users that the extension is only meant to be used on macOS?

I think VSC is being unnecessarily strict in this regard.
@alexdima alexdima added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 27, 2017
@alexdima alexdima added this to the September 2018 milestone Sep 17, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
2 participants
@fabiospampinato @alexdima