-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow Gesture/BaseActionItem #37917
Comments
Not sure who owns this... I started this 5 years ago but I don't feel responsible for it. |
Is there any way to find out if the device is touch enabled or not. @alexandrudima ? |
I can look into this. |
@bpasero I don't know |
I have tested the above check on my MBP and X1 with the results one would expect... |
Also https://bugs.chromium.org/p/chromium/issues/detail?id=784027&can=2&q=addeventlistener%20touch&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified from #37818 so it may just get fixed on Chrome's end. |
@jrieken I have pushed a potential fix for this, however the results are not that much different than your initial run I double checked if the touch check works on my mac (false) and x1(true) and all is good. |
No, the slow bit is creating |
Can we fold this into |
There following problems should be tacked (ideally in this order)
|
Fixed via #38946 I verified all the touch behavior works as before including the balistic scroll. Just fyi @joaomoreno @alexandrudima in case somebody reports touch scroll issues in the editor or the tree that you assign to me. |
DomListener
-type is a heavy hitter and takes ~45ms of which ~80% are spend in setting up theGesture
CPU-20171109T111657.cpuprofile.txt
It seems that adding the
touch{start/move/end/}
events takes a lot longer than other event listener... Suggestions:BaseActionItem
but per container (action bar)The text was updated successfully, but these errors were encountered: