Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php.suggest.basic list appears after closing any HTML tag in a PHP file #37919

Closed
willpower232 opened this issue Nov 9, 2017 · 5 comments
Closed

php.suggest.basic list appears after closing any HTML tag in a PHP file #37919

willpower232 opened this issue Nov 9, 2017 · 5 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug php PHP support issues verified Verification succeeded
Milestone
November 2017

Comments

@willpower232
Copy link

  • VSCode Version: 1.18
  • OS Version: Windows 10

When typing HTML into a PHP file, the php.suggest.basic list appears after closing each tag (presumably on the press of the > key).

image

The problem goes away if I set php.suggest.basic: false but it didn't do this with the previous version.

Steps to Reproduce:

  1. Type HTML into a PHP file

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the php PHP support issues label Nov 9, 2017
@willpower232
Copy link
Author

Similar to atom/ide-php#47 which is the start of a trail to microsoft/language-server-protocol#138

@roblourens
Copy link
Member

This was the cost of #26598, and needs microsoft/language-server-protocol#138 to be fixed

@roblourens roblourens added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Nov 9, 2017
@bmewburn
Copy link

bmewburn commented Nov 9, 2017

Would checking for the - that precedes > in the completion provider solve this? If it does not exist then return an empty completion list.

@roblourens
Copy link
Member

Yeah, that would probably be a good workaround.

@roblourens roblourens mentioned this issue Nov 13, 2017
Closed
@felixfbecker
Copy link
Contributor

Implemented in felixfbecker/php-language-server#527

This was referenced Nov 16, 2017
Closed
Closed
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug and removed upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 29, 2017
@roblourens roblourens added this to the November 2017 milestone Nov 29, 2017
@roblourens roblourens mentioned this issue Nov 29, 2017
Closed
@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2017
@roblourens roblourens mentioned this issue Dec 6, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug php PHP support issues verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
5 participants
@roblourens @willpower232 @bmewburn @felixfbecker @mjbvz