I couldn't reproduce this using a simple gulp file.

@mickeypearce can you provide a GitHub repository that demos this
@Tyriar assigning to you since the crash happens in winpty.dll

I made a simple demo repository (https://github.com/mickeypearce/vscode-taskproblem) that reproduces error on my machine. Please let me know if you can reproduce.

Screenshot after I run the task:

Having the same issue with a simple task that runs a node script:

test.js:
console.log("foobar");

tasks.json:

It shows foobar in the terminal but the task never ends. Terminating gives the exact same assertion popup. It just started when upgrading to 1.18.0 (Windows 10).

The problem is that the terminal crashes and doesn't send a final event onExit event hence the task system thinks the task is still running. Hence you can't rerun the task.

@Tyriar since more people are seeing this can you please investigate. This might be a candidate for a recovery build.

Tried to reproduce this using the examples provided but was not able to do so.

@Tyriar to mitigate this it would help if the terminal service sends and event when the terminal process crashes / dies. Then the task service could at least clean up its state and the user could try to run the task again.

I think the not finishing is this #31301

As for the assertion, I would guess it's a race condition related to the process leak fix microsoft/node-pty#122

https://github.com/Tyriar/node-pty/blob/01f79cfd3a222aaee2977fefde35ef798a921b38/src/windowsPtyAgent.ts#L99

The assertion is actually happening in the new winpty API

https://github.com/Tyriar/node-pty/blob/01f79cfd3a222aaee2977fefde35ef798a921b38/deps/winpty/src/libwinpty/winpty.cc#L942

The error occurs when querying winpty_get_console_process_list when the pty handle has already been evicted from ptyHandles.

Upstream issue: microsoft/node-pty#158

PR is out microsoft/node-pty#160

Since the team had difficulty reproducing the issue, it would be great if someone that can repro could test this build to see if it still occurs: https://az764295.vo.msecnd.net/insider/5676c71a4c02632e14c97aefc049e339848552e6/VSCodeSetup-x64-1.18.0-insider.exe

That build fixed it for me. Tasks are finishing normally again.

I had a similar issue and that build also fixed it for me.

Same here. It works.

Same here. It works too.

October Recovery 1.18.1 fixes it for me thanks

to me too

Thanks a lot for helping with verification 🙂