Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search in folder, doing the search only in opened files... #38165

Closed
arshavskiy opened this issue Nov 12, 2017 · 10 comments
Closed

search in folder, doing the search only in opened files... #38165

arshavskiy opened this issue Nov 12, 2017 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@arshavskiy
Copy link

  • VSCode Version: Code 1.18.0 (dcee220, 2017-11-08T21:19:36.079Z)
  • OS Version: Windows_NT ia32 6.1.7601
  • Extensions:
Extension Author (truncated) Version
html-snippets abu 0.1.0
angular1-code-snippets ale 0.0.3
npm-intellisense chr 1.3.0
path-intellisense chr 1.4.2
angular2-snippets dan 1.0.16
jshint dba 0.10.15
vscode-eslint dba 1.4.3
jquerysnippets don 0.0.1
tslint eg2 1.0.21
vscode-npm-script eg2 0.3.3
code-runner for 0.8.3
angular-bootstrap her 4.0.6
vue-snippets hol 0.1.5
beautify Hoo 1.1.1
search-node-modules jas 1.2.0
Angular2 joh 2.10.0
angular1-code-snippets-johnpapastyle lpe 0.1.0
code-beautifier mic 1.7.2
Angular-BeastCode Mik 5.0.14
easy-less mrc 1.4.5
vscode-less mrm 0.6.3
mssql ms- 1.2.1
debugger-for-chrome msj 3.5.0
language-vscode-javascript-angular2 nwa 0.0.11
sort-imports pet 3.0.1
ejs-language-support Qas 0.0.1
view-in-browser qin 0.0.5
autoimport ste 1.5.3
nodejs-extension-pack wad 0.1.9
vscode-todo-highlight way 0.5.11
bootstrap-3-snippets wcw 0.1.0
JavaScriptSnippets xab 1.5.0
html-css-class-completion Zig 1.14.0

(4 theme extensions excluded)


Steps to Reproduce:

Reproduces without extensions: Yes/No

@vscodebot vscodebot bot added the javascript JavaScript support issues label Nov 12, 2017
@mjbvz mjbvz added info-needed Issue requires more information from poster and removed javascript JavaScript support issues labels Nov 13, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Nov 13, 2017

Please describe what is going wrong and provide some steps to reproduce the issue

@Wo1fie
Copy link

Wo1fie commented Nov 16, 2017

I am experiencing this issue as well. It started for me today when I updated VS Code and installed this morning's VS Code Insider. It occurs on both VS Code and Insiders.

Steps to Reproduce:

  1. Open a Folder (mine happens to be through samba)
  2. Ctrl + Shift + F
  3. Expand elipse and add files to include. Mine is *.cfm,*.cfc also occurs with using **/*.cfm,**/*.cfc (Formatting is hard)
  4. Search for anything (like 'a' or a space)
  5. See no results unless they exist in a file opened in a tab.
  • VSCode Version: Code 1.18.0 (dcee220, 2017-11-08T21:19:36.079Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author (truncated) Version
html-snippets abu 0.1.0
vscode-npm-script eg2 0.3.3
vscode-great-icons emm 2.1.20
php-debug fel 1.11.1
php-intellisense fel 1.5.4
azure-account ms- 0.2.2
cpptools ms- 0.14.2
csharp ms- 1.13.1
mono-debug ms- 0.15.8
PowerShell ms- 1.5.0
vscode-docker Pet 0.0.22
partial-diff ryu 0.5.0
ColdFusion Ske 0.0.1
vscode-hexdump sle 1.6.0
twig wha 1.0.2

(11 theme extensions excluded)

  • VSCode Version: Code - Insiders 1.19.0-insider (3a7d517, 2017-11-15T05:17:28.098Z)
  • OS Version: Windows_NT x64 10.0.14393
  • Extensions:
Extension Author (truncated) Version
vscode-cfml Kam 0.1.4

@mjbvz mjbvz assigned roblourens and unassigned mjbvz Nov 16, 2017
@roblourens
Copy link
Member

Are there any errors in the search output pane?

image

@Wo1fie
Copy link

Wo1fie commented Nov 17, 2017

This seems to only happen when using "Files to include" filter with search in files over the network via UNC paths. It occurs whether I run VS Code normally or as administrator. When I use "whoami" in VS Code's Powershell it shows my proper domain and user which has permissions to the linux server through samba. The filtered search works normally on local directories and the output is basically identical (replace UNC path with local path by opening local folder and it works).

Here is the search output (github code tag not working for me):

`

rg --hidden --heading --line-number --color 'ansi' --colors 'path:none' --colors 'line:none' --colors 'match:fg:red' --colors 'match:style:nobold' --ignore-case -g '//server/folder/**/*.cfm/**' -g '//server/folder/**/*.cfm' --max-filesize '314572800' --no-ignore --follow --fixed-strings -- 'a' '\\server\folder'
- cwd: c:/
- Sibling clauses: {}
No files were searched, which means ripgrep probably applied a filter you didn't expect. Try running again with --debug.

`

  • VSCode Version: Code 1.18.1 (929bacb, 2017-11-16T18:32:36.026Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions: Extensions are disabled

Reproduces without extensions: Yes

@roblourens
Copy link
Member

Somehow the slashes get flipped

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues and removed info-needed Issue requires more information from poster labels Nov 17, 2017
@davide-rota
Copy link

Hello, same problem: happens on a local folder.
Search works if I disable Ripgrep.

This is the output:

`rg --hidden --heading --line-number --color 'ansi' --colors 'path:none' --colors 'line:none' --colors 'match:fg:red' --colors 'match:style:nobold' --ignore-case -g '!/Scripts//.git' -g '!/Scripts//.svn' -g '!/Scripts//.hg' -g '!/Scripts//CVS' -g '!/Scripts//.DS_Store' -g '!/Scripts//node_modules' -g '!/Scripts/**/bower_components' --max-filesize '17179869184' --no-ignore --follow --fixed-strings -- 'write' 'c:\Scripts'

  • cwd: c:/
  • Sibling clauses: {}
    c:\Scripts: Access is denied. (os error 5)`

@roblourens roblourens added this to the November 2017 milestone Nov 21, 2017
@roblourens roblourens modified the milestones: November 2017, December 2017 Dec 4, 2017
@ddeath
Copy link

ddeath commented Dec 4, 2017

Same here, search works only in opened files. I am using Linux version.

@FelikZ
Copy link

FelikZ commented Dec 6, 2017

Same here in 1.18.1, please like the topic, so it get better priority!

Happened after switch to multi-root project structure. Maybe its not related, but some projects are searchable, some are not.

@FelikZ
Copy link

FelikZ commented Dec 28, 2017

1.19.1 - still does not work. Does nobody using an integrated search feature?)

@roblourens
Copy link
Member

This issue is tracking the search includes not working correctly in UNC paths. @davide-rota 's issue may be with searching in a onedrive-tracked directory, like #35433?

@FelikZ please open a new issue with as many details about your setup as possible, including the info from the search output pane as above.

@octref octref added verified Verification succeeded and removed verified Verification succeeded labels Feb 1, 2018
@chrmarti chrmarti added the verified Verification succeeded label Feb 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

10 participants