Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read property 'on' of undefined #38195

Closed
vscodeerrors opened this issue Nov 13, 2017 · 3 comments
Closed

Cannot read property 'on' of undefined #38195

vscodeerrors opened this issue Nov 13, 2017 · 3 comments
Assignees
@roblourens @chrmarti
Labels
error-telemetry VS Code - Issues generated by telemetry search Search widget and operation issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
June 2018

Comments

@vscodeerrors
Copy link

Issue Id: 93967e3d-29cd-adf2-a0e4-0bb5a511c5a3

Versions
- 1.18.0
Stack
TypeError: Cannot read property 'on' of undefined
/vs/workbench/services/search/node/fileSearch.ts#L411:9 (on)
/vs/workbench/services/search/node/fileSearch.ts#L389:7 (forwardData)
/vs/workbench/services/search/node/fileSearch.ts#L233:7 (collectStdout)
/vs/workbench/services/search/node/fileSearch.ts#L200:7 (apply)
/vs/workbench/services/search/node/fileSearch.ts#L182:9 (call)
/vs/base/node/flow.ts#L25:2 (fn)
at Array.forEach (native)
/vs/base/node/flow.ts#L24:6 (forEach)
/vs/workbench/services/search/node/fileSearch.ts#L181:8 (parallel)
/vs/workbench/services/search/node/fileSearch.ts#L548:10 (clb)
@vscodebot vscodebot bot added the search Search widget and operation issues label Nov 13, 2017
@bpasero bpasero added the error-telemetry VS Code - Issues generated by telemetry label Nov 13, 2017
@roblourens
Copy link
Member

I don't know how cmd.stdout would be undefined. https://github.com/Microsoft/vscode/blob/dcee2202709a4f223185514b9275aa4229841aa7/src/vs/workbench/services/search/node/fileSearch.ts#L389:7

@chrmarti
Copy link
Contributor

I think we've seen this in error telemetry before. May be Node acting outside its documentation.

@roblourens roblourens added the debt Code quality issues label Nov 27, 2017
@roblourens roblourens mentioned this issue Jan 3, 2018
Closed
@chrmarti chrmarti added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed debt Code quality issues labels Feb 5, 2018
@chrmarti chrmarti mentioned this issue Mar 12, 2018
Closed
@roblourens roblourens mentioned this issue Jun 13, 2018
Closed
@roblourens
Copy link
Member

I added a null check. It also logs if stdout turns out to be null.

@roblourens roblourens added this to the June 2018 milestone Jun 13, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@chrmarti chrmarti

Labels
error-telemetry VS Code - Issues generated by telemetry search Search widget and operation issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
4 participants
@roblourens @bpasero @chrmarti @vscodeerrors