Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitoring to prevent #35992 and #36920 in the future #38324

Closed
schachmat opened this issue Nov 14, 2017 · 5 comments
Closed

Add monitoring to prevent #35992 and #36920 in the future #38324

schachmat opened this issue Nov 14, 2017 · 5 comments
Assignees
@Tyriar @chrmarti
Labels
install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux
Milestone
November 2017

Comments

@schachmat
Copy link

Please setup some kind of monitoring to detect+fix/prevent bugs like #35992 and #36920 in the future. Possible ideas for how you can achieve this are in the comments of those two bugs.
@vscodebot vscodebot bot added the workbench label Nov 14, 2017
@schachmat schachmat mentioned this issue Nov 14, 2017
Closed
@chrmarti chrmarti assigned Tyriar and chrmarti and unassigned bpasero Nov 14, 2017
@chrmarti chrmarti added linux Issues with VS Code on Linux and removed workbench labels Nov 14, 2017
@bpasero bpasero added the install-update VS Code installation and upgrade system issues label Nov 15, 2017
@chrmarti
Copy link
Contributor

The repo team recommends we use -addfile instead of -addpkg for uploading.

chrmarti added a commit that referenced this issue Nov 20, 2017
@chrmarti
Use -addfile instead of -addpkg (#38324)
c93e6c6
chrmarti added a commit that referenced this issue Nov 20, 2017
@chrmarti
Update script (#38324)
4df58c0
@chrmarti
Copy link
Contributor

@joaomoreno FYI: I have updated how we push the .deb package to the repository. (In case this fails in the next insiders.)

@chrmarti
Copy link
Contributor

Had to rerun the Linux 64-bit build because the scheduled one got canceled for unknown reasons. The rerun succeeded and published the Debian package (commit 38b13c8).

chrmarti added a commit that referenced this issue Nov 21, 2017
@chrmarti
Clean up (#38324)
f4e39a5
@chrmarti
Copy link
Contributor

-addfile should be more robust than -addpkg. I'm closing this issue as separate monitoring really shouldn't be necessary, the publishing steps should succeed or fail reliably.

@chrmarti chrmarti added this to the November 2017 milestone Nov 21, 2017
@Tyriar
Copy link
Member

Tyriar commented Dec 12, 2017

Thanks for doing this @chrmarti!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@chrmarti chrmarti

Labels
install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
4 participants
@bpasero @Tyriar @schachmat @chrmarti