Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect processing "set variable" while debugging with supportsSetVariable =false #38370

Closed
ocheretnyy opened this issue Nov 15, 2017 · 3 comments
Closed

Incorrect processing "set variable" while debugging with supportsSetVariable =false #38370

ocheretnyy opened this issue Nov 15, 2017 · 3 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
November 2017

Comments

@ocheretnyy
Copy link

ocheretnyy commented Nov 15, 2017 •
edited

  • VSCode Version:1.18.0
  • OS Version:Windows 7

My debug adapter do not support set variable capability (supportsSetVariable = false). In the VARIABLES Panel contex menu "Set Value" is disable (it is right p1) but if user double click on variable vscode start set variable procedure (opens the editing input p2)

p0

p1

p2

Steps to Reproduce:

  1. In debug adapter on InitializeRequest set Capabilities.supportsSetVariable = false
  2. Start debug
  3. Pause or make breakpoint
  4. In the VARIABLES Panel do double click

Reproduces without extensions: Yes/No
@vscodebot vscodebot bot added new release debug Debug viewlet, configurations, breakpoints, adapter issues labels Nov 15, 2017
@ocheretnyy ocheretnyy reopened this Nov 15, 2017
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Nov 15, 2017
@weinand weinand removed their assignment Nov 15, 2017
@weinand weinand added this to the November 2017 milestone Nov 15, 2017
@weinand
Copy link
Contributor

weinand commented Nov 15, 2017

I can easily reproduce with mock-debug.
It seems that a "setVariables" request is not called but that the UI still shows an edit box and accepts a new value.

@ocheretnyy
Copy link
Author

If supportsSetVariable = false - UI should not show edit box and should not send setVariables request.
In debug adapter setVariables request is call, but my adapter does not support set variable, and send empty body response

@isidorn
Copy link
Contributor

isidorn commented Nov 17, 2017

@ocheretnyy good catch thanks

@aeschli aeschli added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
5 participants
@weinand @isidorn @kieferrm @aeschli @ocheretnyy