Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new .vscode/launch.json does not respect value of "files.eol" #38496

Closed
jorgenpersson opened this issue Nov 16, 2017 · 3 comments
Closed

new .vscode/launch.json does not respect value of "files.eol" #38496

jorgenpersson opened this issue Nov 16, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@jorgenpersson
Copy link

  • VSCode Version:
$ code --version
1.18.0
dcee2202709a4f223185514b9275aa4229841aa7
  • OS Version: Win10

Steps to Reproduce:

  1. Start a new instance of git-bash.exe

  2. In it bash terminal:

mkdir eoltest
cd eoltest
code .
  1. In code:
  • Open Settings
  • Search for eol
  • Verify that files.eol has value \r\n
  • Add a new configuration and save the file
  1. In it bash terminal execute grep command. Should produce output for all lines containing \r
    grep -U $'\015' .vscode/launch.json

  2. To validate the above command, convert the file to use windows line endings and run it again

unix2dos.exe .vscode/launch.json
grep -U $'\015' .vscode/launch.json

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Nov 16, 2017
@Tyriar Tyriar assigned sandy081 and unassigned Tyriar Dec 15, 2017
@Tyriar Tyriar added config VS Code configuration, set up issues and removed terminal Integrated terminal issues labels Dec 15, 2017
@Tyriar
Copy link
Member

Tyriar commented Dec 15, 2017

@sandy081 assigning to you for config, may be debug-specific though.

@sandy081 sandy081 added debug Debug viewlet, configurations, breakpoints, adapter issues and removed config VS Code configuration, set up issues labels Dec 18, 2017
@sandy081 sandy081 assigned isidorn and unassigned sandy081 Dec 18, 2017
@sandy081
Copy link
Member

@isidorn I assume you are not using configuration service to write debug stuff. Hence assigning to you.

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Dec 18, 2017
@isidorn isidorn added this to the Backlog milestone Dec 18, 2017
@isidorn
Copy link
Contributor

isidorn commented Dec 18, 2017

I acknowledge the bug, here a code pointer in case some user is passionate about fixing it
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/electron-browser/debugConfigurationManager.ts#L541

@isidorn isidorn modified the milestones: Backlog, June 2018 Jun 5, 2018
@isidorn isidorn closed this as completed in 1080200 Jun 5, 2018
@chrmarti chrmarti added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants