Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension recommendations for mimetypes not supported out of the box #38543

Closed
ramya-rao-a opened this issue Nov 16, 2017 · 10 comments
Closed
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Nov 16, 2017

There are a lot of file types that are not supported out of the box in VS Code and need extensions to provide the most basic of features like syntax highlighting and simple language support.

This feature request is to add such extensions for popular file types to our recommendation list so that the current recommendation system can prompt the user when such files are first opened.

Examples:

  • sass
  • stylus
  • cake

@Microsoft/vscode and community members, please add more here as you see fit

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Nov 16, 2017
@ramya-rao-a ramya-rao-a added the feature-request Request for new features or functionality label Nov 16, 2017
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, November 2017 Nov 16, 2017
@octref
Copy link
Contributor

octref commented Nov 16, 2017

I suggest https://marketplace.visualstudio.com/items?itemName=slevesque.shader by @stef-levesque for HLSL / GLSL / Cg.

@bmewburn
Copy link

bmewburn commented Nov 16, 2017

Hi @ramya-rao-a , would you consider adding intelephense to the recommendations. It's PHP and there are already some recommendations for that but it is currently the highest rated most full featured PHP language server extension yet one of the least downloaded

@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Nov 17, 2017

@bmewburn Right this moment, we are not taking any call. This issue is to collect feedback and suggestions. At the end of next week or so, we'll do a sweep through of the suggestions here and pick extensions and revise the recommendations for the next release

@alexdima
Copy link
Member

alexdima commented Dec 7, 2017

@ramya-rao-a This item is on November. Assigning to you to decide what you want to do

@ramya-rao-a ramya-rao-a modified the milestones: November 2017, December 2017 Dec 7, 2017
@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Jan 2, 2018

An alternative to keeping track of a white list of unsupported file extensions and the corresponding recommendations is to

  • show a prompt that says Support for files with extension abc is better with extensions from the marketplace.
  • One of the options in the prompt would be Search marketplace
  • Another option would be Never show again which would ensure that no further prompts are made for the file extension abc
  • Third option would be Close

We already have the infrastructure in place to run the said search. And #40269 is the PR for the same.

The only catch now is that we may want to maintain a whitelist of file extensions for which we DO NOT want to do the above. For example: .txt, .log

cc @seanmcbreen

@ramya-rao-a ramya-rao-a changed the title Additions to the filebased recommendations Add extension recommendations for mimetypes not supported out of the box Jan 2, 2018
@ramya-rao-a
Copy link
Contributor Author

Final cut:

  • When a file with unknown/unsupported file type is opened, a search for related extensions in the marketplace is made in the background
  • If the above search yields any results, then user is prompted about it with an option to search and display the same
  • The prompt is never repeated regardless of what the user reaction to the prompt is. This is unlike the extension recommendation prompt which re-appears as long as user chooses not to do so.

@DanTup
Copy link
Contributor

DanTup commented Jan 19, 2018

Just tested this out in insiders (sent here from #41866) and it works great:

screen shot 2018-01-19 at 19 25 56

screen shot 2018-01-19 at 19 26 05

Thanks!

@ramya-rao-a ramya-rao-a added the verification-needed Verification of issue is requested label Jan 29, 2018
@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2018

I tried this with file foo.stencil and foo.stylus, but never saw the prompt. Tested on Linux and OSX.

  • create a file `foo.stencil'
  • open the file in the editor, wait

@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2018

Ok, now I see it when starting VSCode on a fresh user data dir. I might have clicked on 'Don't show again some time` some time, but surely not for these extensions.

@ramya-rao-a
Copy link
Contributor Author

@aeschli Did you have extensions.ignoreRecommendations set to true before? That would disable these prompts as well

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants