Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watermark layout takes 10ms on window resize #38556

Closed
mjbvz opened this issue Nov 16, 2017 · 3 comments
Closed

Watermark layout takes 10ms on window resize #38556

mjbvz opened this issue Nov 16, 2017 · 3 comments
Assignees
@chrmarti
Labels
important Issue identified as high-priority perf
Milestone
November 2017

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 16, 2017 •
edited

Repo

  1. Resize VS Code window

Bug
Notice that watermark layout takes a significant amount of time, even though it is hidden. This is due to a call to getClientBoundingRect
@mjbvz mjbvz added the perf label Nov 16, 2017
@mjbvz mjbvz assigned mjbvz and chrmarti and unassigned mjbvz Nov 16, 2017
@bpasero
Copy link
Member

bpasero commented Nov 27, 2017 •
edited

This is bad, when resizing the sidebar, this is now the top hit:

image

CPU-20171127T144842.cpuprofile.zip

@bpasero bpasero added the important Issue identified as high-priority label Nov 27, 2017
@bpasero bpasero added this to the November 2017 milestone Nov 27, 2017
@chrmarti
Copy link
Contributor

Turns out we have that size already, we just need to surface it in the event.

@bpasero
Copy link
Member

bpasero commented Nov 28, 2017

@chrmarti thanks 👍

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
important Issue identified as high-priority perf
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
3 participants
@bpasero @chrmarti @mjbvz